Plugins » Discovery

Puppet importer taxonomy code (set_taxonomies) is causing problems for discovery, this is a regression. We had no tests for this in discover and that's the reason why this was easy to introduce. This is the timeline:

- Bug in older version of Foreman
- Fix in Foreman 1.14
- Regression in Foreman 1.17
- Fix no. 2 merged for Foreman 1.22

Fix:
https://github.com/theforeman/foreman/commit/c49eb07f93f6821d7a7cad518ef537cd9ca41478

Regression:
https://github.com/theforeman/foreman/commit/715d097cbd058d171c8a2c65ad5d519d128d1123

Fix 2:
https://github.com/theforeman/foreman/pull/6478

This patch adds more tests around taxonomy and makes sure that taxonomy does not gets overriden by core importing taxonomy setting mechanism again. In order to make the tests effective, this patch also removes "foreman_organization" and "foreman_location" taxonomy detection, this can be easily changed by users to the same fact but with different name: "discovery_organization" and "discovery_location".