Project

General

Profile

Refactor #26707

remove all linting ignores from bundle.js

Added by Ohad Levy 6 months ago. Updated 6 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
JavaScript stack
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:

Description

webpack/assets/javascripts/bundle.js has many linting checked that are skipped.

Associated revisions

Revision 0ee9065d (diff)
Added by Ohad Levy 6 months ago

fixes #26707 - remove unneeded linting skips

Revision b27121a9 (diff)
Added by Ondřej Pražák 6 months ago

Refs #26707 - Make storybook work

imports are 'hoisted' - all the modules
will be loaded before running any code,
which made storybook complain
about missing jQuery

History

#1 Updated by The Foreman Bot 6 months ago

  • Assignee set to Ohad Levy
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/6718 added

#2 Updated by Ondřej Pražák 6 months ago

  • Status changed from Ready For Testing to Closed
  • Fixed in Releases 1.23.0 added

#3 Updated by The Foreman Bot 6 months ago

  • Pull request https://github.com/theforeman/foreman/pull/6725 added

Also available in: Atom PDF