Project

General

Profile

Bug #26758

Unify render_error in unattended and template rendering

Added by Lukas Zapletal 5 months ago. Updated about 2 months ago.

Status:
Closed
Priority:
Normal
Category:
Templates
Target version:
Difficulty:
Triaged:
Yes
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

Getting wrong number of arguments:

app/controllers/unattended_controller.rb:83:in `render_error'
app/controllers/concerns/foreman/controller/template_rendering.rb:19:in `rescue in safe_render'
app/controllers/concerns/foreman/controller/template_rendering.rb:15:in `safe_render'
app/controllers/concerns/foreman/controller/template_rendering.rb:9:in `render_template'
app/controllers/unattended_controller.rb:130:in `render_provisioning_template'
app/controllers/unattended_controller.rb:68:in `host_template'
app/controllers/concerns/foreman/controller/timezone.rb:10:in `set_timezone'
app/models/concerns/foreman/thread_session.rb:32:in `clear_thread'
app/controllers/concerns/foreman/controller/topbar_sweeper.rb:12:in `set_topbar_sweeper_controller'
lib/foreman/middleware/telemetry.rb:10:in `call'
lib/foreman/middleware/catch_json_parse_errors.rb:9:in `call'
lib/foreman/middleware/logging_context_session.rb:22:in `call'
lib/foreman/middleware/logging_context_request.rb:11:in `call'

Associated revisions

Revision 6bb54875 (diff)
Added by Lukas Zapletal about 2 months ago

Fixes #26758 - unify renderer_error helper

History

#1 Updated by The Foreman Bot 5 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/6746 added

#2 Updated by Lukas Zapletal about 2 months ago

  • Target version set to 1.23.0

Actually 1.23 is affected too.

#3 Updated by The Foreman Bot about 2 months ago

  • Fixed in Releases 1.24.0 added

#4 Updated by Tomer Brisker about 2 months ago

  • Fixed in Releases 1.23.0 added
  • Fixed in Releases deleted (1.24.0)

#5 Updated by Lukas Zapletal about 2 months ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF