Project

General

Profile

Refactor #26904

ignore pending pulp tasks as part of vcr recording

Added by Justin Sherrill 5 months ago. Updated 2 months ago.

Status:
Closed
Priority:
Normal
Category:
Tests
Target version:
Branch:
Difficulty:
Triaged:
Yes
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

via this mechanism: https://relishapp.com/vcr/vcr/v/3-0-3/docs/hooks/before-record-hook#prevent-recording-by-ignoring-interaction-in-before-record-hook

we can selectively not ignore certain requests, we can use this to reduce the size of our recordings

Associated revisions

Revision 29354f2c (diff)
Added by Justin Sherrill 2 months ago

Fixes #26904 - improve vcr testing

This commit improves vcr testing in a couple ways:
1. It does not record pending task requests. This means that all
tasks will appear to finish correctly after the first task poll during
playback. This provides smaller cassettes as well as faster test runs.
In my testing i saw about a 30-50% speed improvement in test execution
for task-heavy tests.

2. executing the tests while running mode=all will now delete
the cassettes before recording. This prevents users from continuing
to re-record the same cassette over and over which has happened in
the past.

Revision 05ef3234 (diff)
Added by Justin Sherrill 2 months ago

Fixes #26904 - cassete updates

History

#1 Updated by Justin Sherrill 5 months ago

  • Subject changed from don't ignore pending pulp tasks as part of vcr recording to ignore pending pulp tasks as part of vcr recording

#2 Updated by Andrew Kofink 5 months ago

  • Triaged changed from No to Yes
  • Target version set to Katello 3.13.0

#3 Updated by The Foreman Bot 4 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/Katello/katello/pull/8145 added

#4 Updated by The Foreman Bot 2 months ago

  • Fixed in Releases Katello 3.14.0 added

#5 Updated by Justin Sherrill 2 months ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF