Actions
Bug #28349
closedPulp2 returns masked string after proxy_password value is set, including set as an empty string/blank
Status:
Closed
Priority:
Normal
Assignee:
Category:
Repositories
Target version:
Description
Proxy user/password/port does not remove after select the 'Http Proxy = No Http Proxy'
Steps:
1. Create a Repo with 'Http Proxy' Global Default/Specific Repo
2. Associate the HTTP Proxy with a repository.
3. Set the proxy password to an empty value.
4. Subsequent respository interaction trigger unnecessary refreshes.
Actual result:
Proxy password is displayed as a masked string.
>> in the pulp2 db > db.repo_importers.find({}) { "_id" : ObjectId("5dd6ce3506c71a7bd3d7623f"), "repo_id" : "5bc050e0-88d7-4f8d-8a75-ab2516b53b74", "importer_type_id" : "yum_importer", "config" : { "feed" : "https://repos.fedorapeople.org/pulp/pulp/fixtures/rpm-unsigned/", "remove_missing" : true, "proxy_host" : "", "ssl_validation" : true, "proxy_password" : "", "download_policy" : "immediate", "proxy_username" : "" }, "last_updated" : ISODate("2019-11-22T14:52:10.174Z"), "last_override_config" : { "num_threads" : 4, "validate" : true }, "_ns" : "repo_importers", "scratchpad" : { "repomd_revision" : 1573300917, "repomd_checksum" : "734ef2769824aeb357165a7959b0c942fad7ce0ba5d8bde12c145d7f4fa0c231" }, "last_sync" : "2019-11-21T17:50:14Z" } >> Check repos details using pulp-admin [vagrant@centos7-katello-devel-stable foreman]$ pulp-admin -u admin -p admin repo list --details --repo-id 5bc050e0-88d7-4f8d-8a75-ab2516b53b74 +----------------------------------------------------------------------+ Repositories +----------------------------------------------------------------------+ Id: 5bc050e0-88d7-4f8d-8a75-ab2516b53b74 Display Name: test Description: None Content Unit Counts: Erratum: 4 Package Category: 1 Package Group: 2 Package Langpacks: 1 Rpm: 35 Notes: Scratchpad: Checksum Type: sha256 Importers: Config: Download Policy: immediate Feed: https://repos.fedorapeople.org/pulp/pulp/fixtures/rpm-unsig ned/ Proxy Host: Proxy Password: ***** Proxy Username: [...]
Expected result
Don't refresh if the importer configs are the same, despite the proxy password returned as a masked string.
Actions