Project

General

Profile

Feature #28420

Support mocha >=1.10

Added by Oleh Fedorenko 6 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Low
Assignee:
-
Category:
-
Target version:
-
Difficulty:
Triaged:
Yes
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:
In Kanboard:

Description

As per https://projects.theforeman.org/issues/28417 we restrict the gem version to lower versions since the newest ones break our tests.

We need to review and rewrite our tests to support the newer versions.


Related issues

Related to Hammer CLI - Bug #28417: mocha 1.10 break testsClosed

Associated revisions

Revision c70052c1 (diff)
Added by James Mead 5 months ago

Fixes #28420: Unpin mocha version & fix deprecation warning (#476)

The regression introduced in mocha v1.10.0 which led to its version
being pinned to v1.9.0 was fixed in mocha v1.11.2 which is currently the
latest version, so it is nowsafe to unpin the version.

Requiring 'mocha/setup' was deprecated in v1.10.0, so I've also fixed
that with the change to `test/test_helper.rb`.

History

#1 Updated by Oleh Fedorenko 6 months ago

  • Related to Bug #28417: mocha 1.10 break tests added

#2 Updated by Shira Maximov 6 months ago

  • In Kanboard set to yes

Changing the

#3 Updated by Shira Maximov 6 months ago

  • In Kanboard deleted (yes)

#4 Updated by Shira Maximov 6 months ago

  • In Kanboard set to yes

Changing in_kanboard field to yes

#5 Updated by Shira Maximov 5 months ago

  • In Kanboard deleted (yes)

#6 Updated by The Foreman Bot 5 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/hammer-cli-foreman/pull/476 added

#7 Updated by Tomer Brisker 5 months ago

  • Related to Bug #28641: Fix mocha deprecation warnings in report_importer added

#8 Updated by Tomer Brisker 5 months ago

  • Related to deleted (Bug #28641: Fix mocha deprecation warnings in report_importer)

#9 Updated by The Foreman Bot 5 months ago

  • Fixed in Releases hammer-cli-foreman-0.20.0 added

#10 Updated by James Mead 5 months ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF