Refactor #28565
Don't use AR's association_scope
Pull request:
Fixed in Releases:
Found in Releases:
Description
association_scope is private in Rails 6 (since https://github.com/rails/rails/commit/0b4cfa2ba3e978386240e0e56a409616cc32fd02):
[...]
NoMethodError: private method `association_scope' called for #<ActiveRecord::Associations::HasManyAssociation:0x00000000100e57f8>
lib/core_extensions.rb:41:in `block in before_destroy'
lib/core_extensions.rb:40:in `each'
lib/core_extensions.rb:40:in `before_destroy'
[...]
Related issues
Associated revisions
History
#1
Updated by Michael Moll 5 months ago
Updated by - Related to Bug #11188: on deleting a capsule: Operation FAILED: ERROR: update or delete on table "smart_proxies" violates foreign key constraint "hosts_puppet_ca_proxy_id_fk" on table "hosts" added
#2
Updated by Michael Moll 5 months ago
- Blocks Tracker #24837: Rails 6.0 Tracker added
#3
Updated by Tomer Brisker 5 months ago
Updated by - Assignee set to Tomer Brisker
- Status changed from New to Assigned
#4
Updated by The Foreman Bot 5 months ago
Updated by - Status changed from Assigned to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/7318 added
#5
Updated by The Foreman Bot 5 months ago
- Fixed in Releases 2.0.0 added
#6
Updated by Tomer Brisker 5 months ago
- Status changed from Ready For Testing to Closed
Applied in changeset bcfbba25d945f7777abb60b31ce96c3ee7383549.
Fixes #28565 - Avoid association_scope method
ActiveRecord::Associations#association_scope has been changed to private
method in Rails 6. We replace it by explicitly creating the
AssociationScope we need.
Additionally, refactored EnsureNotUsedBy callback to be more efficient
by only loading the authorized associations' ids once instead of loading
all of the records again for every existing association still present.