Bug #29035: missing @taxonomy instance variable when creating organization from API - Katello - Foreman

Actions

Copy link

Bug #29035

closed

missing @taxonomy instance variable when creating organization from API

Added by Shira Maximov almost 5 years ago. Updated over 4 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Shira Maximov

Category:

API

Target version:

Katello 3.16.0

Difficulty:

Triaged:

Yes

Bugzilla link:

Pull request:

https://github.com/Katello/katello/pull/8568

Fixed in Releases:

Katello 3.16.0

Found in Releases:

Red Hat JIRA:

Description

I've created this PR:
https://github.com/theforeman/foreman/pull/7434
which add location inherited parameters.

this PR cause to some failures in katello, for example :

Error Message
Expected {"message"=>"resource have no errors"} to be nil.
Stacktrace
Expected {"message"=>"resource have no errors"} to be nil. (Minitest::Assertion)
/home/jenkins/workspace/test_develop_pr_katello@2/database/postgresql/ruby/2.5/slave/fast/plugin/test/controllers/api/v2/organizations_controller_test.rb:198

the failures are related to fact I used `ancestors = @taxonomy.ancestors` In my PR, but @taxonomy is not an instance variable

the fix for it will be to set @taxonomy instance variable when creating an organization