Project

General

Profile

Actions

Bug #29035

closed

missing @taxonomy instance variable when creating organization from API

Added by Shira Maximov about 4 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
API
Target version:
Difficulty:
Triaged:
Yes
Fixed in Releases:
Found in Releases:

Description

I've created this PR:
https://github.com/theforeman/foreman/pull/7434
which add location inherited parameters.

this PR cause to some failures in katello, for example :

Error Message
Expected {"message"=>"resource have no errors"} to be nil.
Stacktrace
Expected {"message"=>"resource have no errors"} to be nil. (Minitest::Assertion)
/home/jenkins/workspace/test_develop_pr_katello@2/database/postgresql/ruby/2.5/slave/fast/plugin/test/controllers/api/v2/organizations_controller_test.rb:198

the failures are related to fact I used `ancestors = @taxonomy.ancestors` In my PR, but @taxonomy is not an instance variable

the fix for it will be to set @taxonomy instance variable when creating an organization

Actions #1

Updated by The Foreman Bot about 4 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/Katello/katello/pull/8568 added
Actions #2

Updated by Samir Jha about 4 years ago

  • Target version set to Katello 3.16.0
  • Triaged changed from No to Yes
Actions #3

Updated by The Foreman Bot about 4 years ago

  • Fixed in Releases Katello 3.16.0 added
Actions #4

Updated by Shira Maximov about 4 years ago

  • Status changed from Ready For Testing to Closed
Actions #5

Updated by Ian Ballou almost 4 years ago

  • Category set to API
Actions

Also available in: Atom PDF