Project

General

Profile

Bug #29035

missing @taxonomy instance variable when creating organization from API

Added by Shira Maximov 5 months ago. Updated about 2 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
API
Target version:
Difficulty:
Triaged:
Yes
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

I've created this PR:
https://github.com/theforeman/foreman/pull/7434
which add location inherited parameters.

this PR cause to some failures in katello, for example :

Error Message
Expected {"message"=>"resource have no errors"} to be nil.
Stacktrace
Expected {"message"=>"resource have no errors"} to be nil. (Minitest::Assertion)
/home/jenkins/workspace/test_develop_pr_katello@2/database/postgresql/ruby/2.5/slave/fast/plugin/test/controllers/api/v2/organizations_controller_test.rb:198

the failures are related to fact I used `ancestors = @taxonomy.ancestors` In my PR, but @taxonomy is not an instance variable

the fix for it will be to set @taxonomy instance variable when creating an organization

Associated revisions

Revision 29f949ec (diff)
Added by Shira Maximov 5 months ago

Fixes #29035 - Add @taxonomy when creating organization from API

History

#1 Updated by The Foreman Bot 5 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/Katello/katello/pull/8568 added

#2 Updated by Samir Jha 5 months ago

  • Triaged changed from No to Yes
  • Target version set to Katello 3.16.0

#3 Updated by The Foreman Bot 5 months ago

  • Fixed in Releases Katello 3.16.0 added

#4 Updated by Shira Maximov 5 months ago

  • Status changed from Ready For Testing to Closed

#5 Updated by Ian Ballou about 2 months ago

  • Category set to API

Also available in: Atom PDF