Project

General

Profile

Actions
Copy link

Refactor #30722

closed

Update ForemanModal to use Patternfly 4

Added by Jeremy Lenz almost 4 years ago. Updated about 3 years ago.

Status:
Rejected
Priority:
Normal
Assignee:
Jeremy Lenz
Category:
Web Interface
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

The ForemanModal React component and associated subcomponents use <Modal> from old patternfly-react, which results in lots of React console warnings. It should be updated to use the current Modal component from @patternfly/react-core.

Actions
Copy link
 #1

Updated by Jeremy Lenz almost 4 years ago

  • Category set to Web Interface
Actions
Copy link
 #2

Updated by Jeremy Lenz about 3 years ago

After thinking about it some more, I don't think having a modal wrapper that keeps state in Redux is adding enough value to keep maintaining. Moving forward with PF4, I think we should just use the Patternfly react-core components directly. And it's better to just leave this ForemanModal component as PF3-only, and its use will slowly go away with PF3. So, closing this issue.

Actions
Copy link
 #3

Updated by Jeremy Lenz about 3 years ago

  • Status changed from New to Rejected
Actions
Copy link

Also available in: Atom PDF