Refactor #30722
closed
Update ForemanModal to use Patternfly 4
Added by Jeremy Lenz almost 4 years ago.
Updated about 3 years ago.
Description
The ForemanModal React component and associated subcomponents use <Modal> from old patternfly-react, which results in lots of React console warnings. It should be updated to use the current Modal component from @patternfly/react-core.
- Category set to Web Interface
After thinking about it some more, I don't think having a modal wrapper that keeps state in Redux is adding enough value to keep maintaining. Moving forward with PF4, I think we should just use the Patternfly react-core components directly. And it's better to just leave this ForemanModal component as PF3-only, and its use will slowly go away with PF3. So, closing this issue.
- Status changed from New to Rejected
Also available in: Atom
PDF