Actions
Bug #31218
closedDisable parameter wrapping for reports
Description
Parameter wrapping is a feature of Rails that adds missing root JSON element in case it's missing. The thing is it uses Hash.merge
method which is slow, it does not work similarly to HashWithIndefferentAccess. Our fact/reports clients do send full JSON documents (including the root elements) so we should be able to disable this behavior for those endpoints without any problems, this patch will prevent anyone else from sending without root elements.
This patch can possibly break 3rd party integrations, howevers it's the purpose - to avoid slow JSON processing. We will do upgrade notes on how to fix this.
Updated by Lukas Zapletal about 4 years ago
- Related to Tracker #31142: New report model and import/view mechanism added
Updated by Lukas Zapletal about 4 years ago
- Subject changed from Disable parameter wrapping for reports and facts to Disable parameter wrapping for reports
Updated by The Foreman Bot about 4 years ago
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/8116 added
Updated by Lukas Zapletal almost 4 years ago
- Status changed from Ready For Testing to Rejected
Working on a new report plugin.
Actions