Project

General

Profile

Actions
Copy link

Refactor #3158

closed

Remove rescues from try calls where method doesn't exist

Added by Dominic Cleal over 11 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Kavita Gaikwad
Category:
Rails
Target version:
1.15.0
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/4085
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

Via #3129, we added rescues to our try calls in app/helpers/compute_resources_vms_helper.rb as the method may not exist. Rails 4.0's #try will return nil instead of throwing an error, so these can be removed.

Related issues 2 (0 open — 2 closed)

Related to Foreman - Tracker #3157: Rails 4.1 upgrade tasksClosed09/27/2013

Actions
Related to Foreman - Bug #3129: unable to show EC2 vm infoClosed09/20/2013Actions
Actions
Copy link
 #1

Updated by Dominic Cleal over 11 years ago

Actions
Copy link
 #2

Updated by Dominic Cleal over 11 years ago

  • Related to Bug #3129: unable to show EC2 vm info added
Actions
Copy link
 #3

Updated by Kavita Gaikwad about 8 years ago

  • Assignee set to Kavita Gaikwad
  • Target version set to 1.15.6
Actions
Copy link
 #4

Updated by The Foreman Bot about 8 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4085 added
Actions
Copy link
 #5

Updated by Kavita Gaikwad about 8 years ago

  • Target version changed from 1.15.6 to 1.15.4
Actions
Copy link
 #6

Updated by Kavita Gaikwad about 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions
Copy link
 #7

Updated by Dominic Cleal about 8 years ago

  • Translation missing: en.field_release set to 209
Actions
Copy link

Also available in: Atom PDF