Project

General

Profile

Bug #328

Set Content-Type header when rendering Unattended Install scripts

Added by Jon Fautley almost 9 years ago. Updated almost 9 years ago.

Status:
Closed
Priority:
Low
Assignee:
Category:
Unattended installations
Target version:
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

Foreman currently uses a default content-type header of text/html when rendering unattended install scripts (Kickstart, Preseed, Jumpstart). This makes viewing them in a browser irritating (need to 'View Source').

Attached is a minor patch against unattended_controller.rb to return the output as text/plain - making it easier to view in a browser, and ensuring the Content-Type header actually matches what gets returned.

My Ruby is appallingly poor, so I apologise now for the state of the patch ;)

set-unattended-content-type.patch set-unattended-content-type.patch 594 Bytes Patch against app/controllers/unattended_controller.rb to add Content-Type HTTP header Jon Fautley, 06/23/2010 09:07 AM
0001-Set-Content-Type-HTTP-header-when-rendering-unattend.patch 0001-Set-Content-Type-HTTP-header-when-rendering-unattend.patch 1011 Bytes Git Formatted Patch Jon Fautley, 06/23/2010 10:01 AM

Associated revisions

Revision d8dd4f92 (diff)
Added by Jon Fautley almost 9 years ago

fixes #238 - Set Content-Type HTTP header when rendering nattended install scripts

Revision 2c279147 (diff)
Added by Julien Pivotto over 3 years ago

Improve systemd.timer integration

  • Change service name to systemd-run
  • Add SuccessExitStatus=2 to the service unit
  • Use Array().join instead of a more complex method
  • Add the ability to change the systemd service name
  • Add the ability to specify different commands for systemd and cron
  • Isolate systemctl-daemon-reload by adding a -puppet suffix
  • Do not duplicate systemctl-daemon-reload exec definition
  • Only use the systemd magic on Linux.
  • Fix tests

Closes #323, #328 and #329.

History

#2 Updated by Ohad Levy almost 9 years ago

  • Status changed from New to Closed
  • Target version set to 0.1-6

Also available in: Atom PDF