Project

General

Profile

Actions

Feature #32900

open

Tracker #32903: Rethinking React-Redux folder structure

Use React testing library

Added by Ron Lavi almost 3 years ago. Updated almost 3 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
JavaScript stack
Target version:
-
Difficulty:
Triaged:
No
Fixed in Releases:
Found in Releases:

Description

Shifting from snapshot testing to more user integration test as explained in https://community.theforeman.org/t/rethinking-react-redux-folder-structure/24183
React testing library's primary principle is: "The more your tests resemble the way your software is used, the more confidence they can give you."
this will also affect our code conventions.

Actions #1

Updated by Ron Lavi almost 3 years ago

  • Category set to JavaScript stack
  • Parent task set to #32903
Actions #2

Updated by Tomer Brisker almost 3 years ago

If i'm not mistaken we already have the react testing library included in foreman-js: https://github.com/theforeman/foreman-js/blob/master/packages/test/package.json#L28
Is there any further action needed to make it usable in foreman core other than using it for new tests?

Actions #3

Updated by Ron Lavi almost 3 years ago

Tomer Brisker wrote:

If i'm not mistaken we already have the react testing library included in foreman-js: https://github.com/theforeman/foreman-js/blob/master/packages/test/package.json#L28
Is there any further action needed to make it usable in foreman core other than using it for new tests?

I guess now we just need to set it up in Foreman and see that there are no conflicts with the jest configuration or other @theforeman/test configs

Actions

Also available in: Atom PDF