Project

General

Profile

Actions

Bug #33130

open

Hammer output message is inconsistent across sub-commands after the entity update

Added by Oleh Fedorenko about 3 years ago. Updated almost 3 years ago.

Status:
Ready For Testing
Priority:
Normal
Category:
Other commands
Target version:
-
Difficulty:
Triaged:
No
Team Backlog:
Fixed in Releases:
Found in Releases:
In Kanboard:

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1984107

Description of problem:
BZ1868310 introduced a new type of message after the entity is updated and when the user provides no extra arguments.
New message: "Nothing to update".
Old message: "<entity_type> updated."
However, this message is not shown for some Hammer sub-commands and the former message "<entity_type> updated." is printed out. This makes the output messages inconsistent across the sub-commands.
Affected sub-commands are listed in the reproducer below.

Version-Release number of selected component (if applicable):
tfm-rubygem-hammer_cli_foreman_remote_execution-0.2.1-2.el7sat.noarch
tfm-rubygem-hammer_cli_foreman_bootdisk-0.3.0-2.el7sat.noarch
tfm-rubygem-hammer_cli_foreman_discovery-1.0.2-2.el7sat.noarch
tfm-rubygem-hammer_cli_foreman_templates-0.2.0-2.el7sat.noarch
tfm-rubygem-hammer_cli_foreman_azure_rm-0.2.1-1.el7sat.noarch
tfm-rubygem-hammer_cli-2.5.1-1.el7sat.noarch
tfm-rubygem-hammer_cli_katello-1.1.2-1.el7sat.noarch
tfm-rubygem-hammer_cli_foreman_admin-0.0.10-1.el7sat.noarch
tfm-rubygem-hammer_cli_foreman_virt_who_configure-0.0.8-1.el7sat.noarch
tfm-rubygem-hammer_cli_foreman_tasks-0.0.15-2.el7sat.noarch
tfm-rubygem-hammer_cli_foreman_ansible-0.3.3-2.el7sat.noarch
tfm-rubygem-hammer_cli_foreman-2.5.1-1.el7sat.noarch
tfm-rubygem-hammer_cli_foreman_openscap-0.1.12-2.el7sat.noarch

How reproducible:
Every time

Steps to Reproduce (hammer sub-command and the actual command that produces the output):
activation-key: hammer activation-key update --organization-id 1 --id 1
ansible (possibly, but I was unable to test it due to BZ1983760)
content-credentials: hammer content-credentials update --id 1
domain: hammer domain update --id 1
filter: hammer filter update --id 336
host: hammer host update --id 1
host-collection: hammer host-collection update --id 1
job-template: hammer job-template update --id 174
virt-who-config: hammer virt-who-config update --id 1

Actual results:
Activation key updated.
Content Credential updated.
Domain [my.vms.redhat.com] updated.
Permission filter for [Config group] updated.
Host updated.
Host collection updated.
Job template updated
Virt Who configuration [myconfig] updated

Expected results:
"Nothing to update" message in all cases.

Additional info:
Sub-commands that are not listed in the reproducer section, produce a "Nothing to update" message or explicitly require additional arguments to be provided by the user.

Actions #1

Updated by The Foreman Bot almost 3 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/hammer-cli-foreman/pull/584 added
Actions #2

Updated by Adi Abramovitch almost 3 years ago

  • Status changed from Ready For Testing to New
  • Assignee set to Adi Abramovitch
  • Pull request deleted (https://github.com/theforeman/hammer-cli-foreman/pull/584)
Actions #3

Updated by The Foreman Bot almost 3 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/hammer-cli-foreman/pull/584 added
Actions #4

Updated by The Foreman Bot almost 3 years ago

  • Pull request https://github.com/theforeman/hammer-cli-foreman/pull/585 added
Actions #5

Updated by Oleh Fedorenko almost 3 years ago

  • Pull request deleted (https://github.com/theforeman/hammer-cli-foreman/pull/585)
Actions #6

Updated by The Foreman Bot almost 3 years ago

  • Pull request https://github.com/theforeman/hammer-cli-foreman/pull/585 added
Actions #7

Updated by Oleh Fedorenko almost 3 years ago

  • Pull request deleted (https://github.com/theforeman/hammer-cli-foreman/pull/585)
Actions

Also available in: Atom PDF