Actions
Bug #33319
closeddon't run npm-fix-foreman-stories.sh on every npm install
Difficulty:
Triaged:
No
Description
Right now, we run npm-fix-foreman-stories.sh in postinstall, so on every "npm install" in Foreman, this gets executed and pulls in thousands of deps.
The script guards by $NODE_ENV != "production", but when building assets for packaging, we don't set NODE_ENV to "production" (probably because we need devDependencies actually installed as it contains webpack etc?)
So my questions would be:
1. can we just move npm-fix-foreman-stories.sh to a step that is not automatically executed on every "npm i"?
2. should we run package builds with NODE_ENV=production?
3. what about CI? are storybooks needed there? my gut is saying no?
Actions