Project

General

Profile

Actions

Bug #34802

closed

Tabbable latest version 5.3.1 is not compatible with jest dom/ JSDom without changes to PF4.

Added by Samir Jha over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Web Interface
Target version:
-
Difficulty:
Triaged:
No
Fixed in Releases:
Found in Releases:

Description

From my debugging and googling, the latest version of Tabbable that is 5.3.0 (and onwards) needs some changes to the Modal/Wizard components in Patternfly4 to be able to support tests.

Specifically this: https://github.com/focus-trap/tabbable#testing-in-jsdom

Modal currently has the prop disableFocusTrap that can be set to false and that lets us work around the issue without ever activating the trap. I spoke to folks on PF4 slack and they lock the version of FocusTrap but Focustrap brings in the latest 5.x.x tabbable causing the test failures.

There's an open PF4 issue around this: https://github.com/patternfly/patternfly-react/issues/7288

Actions

Also available in: Atom PDF