Project

General

Profile

Actions

Refactor #37112

closed

Remove 'query-string' JS dependency

Added by Jeremy Lenz 11 months ago. Updated 6 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Web UI
Target version:
Branch:
Difficulty:
Triaged:
Yes

Description

We use the 'query-string' library in a few places to parse query string params:

https://github.com/search?q=repo%3AKatello%2Fkatello%20query-string&type=code

it's been requested we remove this dependency in favor of native JS or using another existing dependency.

Actions #1

Updated by Eric Helms 11 months ago

Additional context:

This will allow us to drop a Katello only NodeJS dependency.
Additionally, the query-string package has not seen an update since 2022.

This will mean we can also drop these packages in our packaging repository:

  • nodejs-decode-uri-component
  • nodejs-strict-uri-encode

[1] https://github.com/search?q=repo%3AKatello%2Fkatello%20query-string&type=code

Actions #2

Updated by Jeremy Lenz 11 months ago

  • Target version set to Katello 4.13.0
  • Triaged changed from No to Yes
Actions #3

Updated by The Foreman Bot 6 months ago

  • Status changed from New to Ready For Testing
  • Assignee set to Jeremy Lenz
  • Pull request https://github.com/Katello/katello/pull/11025 added
Actions #4

Updated by The Foreman Bot 6 months ago

  • Fixed in Releases Katello 4.14.0 added
Actions #5

Updated by Jeremy Lenz 6 months ago

  • Status changed from Ready For Testing to Closed
Actions #6

Updated by The Foreman Bot 6 months ago

  • Pull request https://github.com/Katello/katello/pull/11051 added
Actions #7

Updated by The Foreman Bot 6 months ago

  • Fixed in Releases Katello 4.13.1 added
Actions

Also available in: Atom PDF