Bug #398
domain wrong if host contians a '.'
Description
http://github.com/ohadlevy/foreman/blob/develop/app/models/host.rb#L451
If host = 'xx-01.xx-02' then the domain will be 'xx-02.mydomain.com' and not 'mydomain.com'
Associated revisions
History
#1
Updated by Matt Moran about 8 years ago
Updated by #2
Updated by Matt Moran about 8 years ago
- File 0001-fixes-bug-398-issue-with-adding-hosts-with-full-stop.patch 0001-fixes-bug-398-issue-with-adding-hosts-with-full-stop.patch added
- Assignee changed from Matt Moran to Ohad Levy
Here's my patch.
#3
Updated by Ohad Levy about 8 years ago
Updated by - Status changed from New to Ready For Testing
- Target version set to 0.1-6
- % Done changed from 0 to 100
#4
Updated by Matt Moran about 8 years ago
Pulled update. Tested okay.
#5
Updated by Ohad Levy about 8 years ago
- Status changed from Ready For Testing to Closed
fixes bug #398 - issue with adding hosts with full stops
This introduce a small behaviour change, before, once adding host like:
x.domain.net, foreman would automatically add domain.net to its domain
list, but now, as a full stop(".") is a valid hostname char,
we can't parse the domain name safely, therefor we expect the user to
make sure that the domain created before creating a host.