Feature #402
closed
Report noop puppet actions seperately
Description
In puppet log, noop operations look like this:
info Puppet Applying configuration version '1286391176'
notice //gu_iptables::redhat/File[iptables]/checksum is {md5}878158421d4824500a101bfea33e60d6, should be md5 (noop)
notice //gu_iptables::redhat/File[iptables]/content is {md5}878158421d4824500a101bfea33e60d6, should be (noop)
info //gu_iptables::redhat/File[iptables] Scheduling refresh of Service[iptables]
notice //gu_iptables::redhat/Service[iptables] Would have triggered refresh from 1 dependencies
This reported by foreman as a successful modification involving two changes.
It would be nice if this was somehow reported as "Changes needed, but not applied"
There is a feature request that seems to be related in puppet: http://projects.puppetlabs.com/issues/3535
Thanks a lot.
Updated by Ohad Levy over 14 years ago
- Category set to Puppet Reports
- Target version set to 0.2
Updated by Ohad Levy about 14 years ago
- Subject changed from Report noop puupet actions seperately to Report noop puppet actions seperately
- Target version changed from 0.2 to 0.3
Updated by Marcello de Sousa almost 14 years ago
It would be awesome to have the ability to just audit a server with noop. That could also be handy during a puppet/foreman upgrade by setting all host to noop mode and see what it would do.
Looks similar to http://projects.puppetlabs.com/issues/6537
Probably obvious but, if this gets implemented I guess we should also have an extra status on the Dashboard displaying the "pending update" hosts (or something like it).
Updated by Ken Barber over 13 years ago
I've added preliminary support:
https://github.com/kbarber/foreman/tree/ticket/402_noop-reports
Doesn't deal with 0.25 probably ... and there are not tests. Screenshots:
https://plus.google.com/u/1/photos/113052903761064527606/albums/5675992194604403937
Updated by Ken Barber over 13 years ago
I've added 'pending' to the main dashboard reports - the table report and pie chart. This report is hyperlinked, there is a 'status.pending' search for hosts now so its easy to search for these hosts. I've changed pending hosts icon to be a 'warning' instead of 'notice' so its more obvious (I'm open for debate on this - it probably should be user configurable ultimately but I have no idea about what the sensible default is).
Changes squashed and pushed back into my branch.
Updated by Ken Barber over 13 years ago
Added tests - and submitted pull request here:
Updated by Ken Barber over 13 years ago
I was thinking of changing the 'noops' columns to just 'pending' ... would this be less obvious to Puppet users?
Updated by Mohamed Lrhazi over 13 years ago
Ken Barber wrote:
I was thinking of changing the 'noops' columns to just 'pending' ... would this be less obvious to Puppet users?
Yeah, "pending" makes sense. It is what puppet dashboard uses too.
Updated by Ken Barber over 13 years ago
Okay - I've changed it to 'pending' instead, changes pushed to branch.
Updated by Ohad Levy over 13 years ago
- Assignee set to Ken Barber
- Target version set to 1.0
Updated by Ohad Levy over 13 years ago
- Status changed from New to Closed
- % Done changed from 0 to 100
Applied in changeset 9b41cf08caf63c343ac3142fb912e914cc15f827.
Updated by Ohad Levy over 13 years ago
somehow git ammend via git gui removed the original author of this patch, full credit goes to Ken, sorry about that mate.