Project

General

Profile

Feature #402

Report noop puppet actions seperately

Added by Mohamed Lrhazi over 8 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Puppet Reports
Target version:
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

In puppet log, noop operations look like this:
info Puppet Applying configuration version '1286391176'
notice //gu_iptables::redhat/File[iptables]/checksum is {md5}878158421d4824500a101bfea33e60d6, should be md5 (noop)
notice //gu_iptables::redhat/File[iptables]/content is {md5}878158421d4824500a101bfea33e60d6, should be (noop)
info //gu_iptables::redhat/File[iptables] Scheduling refresh of Service[iptables]
notice //gu_iptables::redhat/Service[iptables] Would have triggered refresh from 1 dependencies

This reported by foreman as a successful modification involving two changes.

It would be nice if this was somehow reported as "Changes needed, but not applied"

There is a feature request that seems to be related in puppet: http://projects.puppetlabs.com/issues/3535

Thanks a lot.

Associated revisions

Revision 9b41cf08 (diff)
Added by Ohad Levy over 7 years ago

fixes #402 - Add noops/pending to metric handling, and provide pending hosts for dashboard views.

This change adds the ability to see noops in metric reports inside
foreman graphs, charts and lists. The business reason for this is to allow
users to run their puppet agents in noop mode, and see where nodes have
converged within the foreman dashboard and various foreman reports.

The status data was always stored in the database, we just had to modify
the views and model to get at it.

This change modifies the dashboard adding the new state 'pending' so it appears
in the pie graph, and adds pending to the report view in the dashboard as well.

Revision 9ec7fdd0 (diff)
Added by Ohad Levy about 7 years ago

refs #402 - ensures that noops reports are shown currectly on all DB's (pg, mysql and sqlite)

History

#1 Updated by Ohad Levy over 8 years ago

  • Category set to Puppet Reports
  • Target version set to 0.2

#2 Updated by Ohad Levy about 8 years ago

  • Subject changed from Report noop puupet actions seperately to Report noop puppet actions seperately
  • Target version changed from 0.2 to 0.3

#3 Updated by Ohad Levy about 8 years ago

  • Target version deleted (0.3)

#4 Updated by Marcello de Sousa almost 8 years ago

It would be awesome to have the ability to just audit a server with noop. That could also be handy during a puppet/foreman upgrade by setting all host to noop mode and see what it would do.

Looks similar to http://projects.puppetlabs.com/issues/6537

Probably obvious but, if this gets implemented I guess we should also have an extra status on the Dashboard displaying the "pending update" hosts (or something like it).

#5 Updated by Ken Barber over 7 years ago

I've added preliminary support:

https://github.com/kbarber/foreman/tree/ticket/402_noop-reports

Doesn't deal with 0.25 probably ... and there are not tests. Screenshots:

https://plus.google.com/u/1/photos/113052903761064527606/albums/5675992194604403937

#6 Updated by Ken Barber over 7 years ago

I've added 'pending' to the main dashboard reports - the table report and pie chart. This report is hyperlinked, there is a 'status.pending' search for hosts now so its easy to search for these hosts. I've changed pending hosts icon to be a 'warning' instead of 'notice' so its more obvious (I'm open for debate on this - it probably should be user configurable ultimately but I have no idea about what the sensible default is).

Changes squashed and pushed back into my branch.

#7 Updated by Ken Barber over 7 years ago

Added tests - and submitted pull request here:

https://github.com/ohadlevy/foreman/pull/14

#8 Updated by Ken Barber over 7 years ago

I was thinking of changing the 'noops' columns to just 'pending' ... would this be less obvious to Puppet users?

#9 Updated by Mohamed Lrhazi over 7 years ago

Ken Barber wrote:

I was thinking of changing the 'noops' columns to just 'pending' ... would this be less obvious to Puppet users?

Yeah, "pending" makes sense. It is what puppet dashboard uses too.

#10 Updated by Ken Barber over 7 years ago

Okay - I've changed it to 'pending' instead, changes pushed to branch.

#11 Updated by Ohad Levy over 7 years ago

  • Assignee set to Ken Barber
  • Target version set to 1.0

#12 Updated by Ohad Levy over 7 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

#13 Updated by Ohad Levy over 7 years ago

somehow git ammend via git gui removed the original author of this patch, full credit goes to Ken, sorry about that mate.

Also available in: Atom PDF