Project

General

Profile

Actions
Copy link

Bug #4785

closed

angular-gettext's gettext function only works for extraction, need to also handle replacements

Added by Walden Raines almost 11 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Walden Raines
Category:
Web UI
Target version:
Katello 2.0
Difficulty:
medium
Triaged:
Yes
Bugzilla link:
Pull request:
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

See https://github.com/rubenv/angular-gettext/issues/29

We have various gettext() calls in our Bastion javascript files that will only return the untranslated string. We need to figure out a way to handle replacement.

A couple of ideas:
  1. Wrap the angular-gettext function with our own version that does replacements
  2. Use what's outlined here: https://github.com/rubenv/angular-gettext/issues/29#issuecomment-37196935
Actions
Copy link
 #1

Updated by Walden Raines almost 11 years ago

  • Status changed from New to Assigned
Actions
Copy link
 #2

Updated by Mike McCune almost 11 years ago

  • Triaged changed from No to Yes
Actions
Copy link
 #3

Updated by Walden Raines almost 11 years ago

  • Status changed from Assigned to Ready For Testing
Actions
Copy link
 #4

Updated by Walden Raines almost 11 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Applied in changeset katello|commit:6f5e909f1dd697105e714fca9789bba4d41e929b.

Actions
Copy link
 #5

Updated by Eric Helms over 10 years ago

  • Translation missing: en.field_release set to 13
Actions
Copy link

Also available in: Atom PDF