Project

General

Profile

Bug #5096

Failed repository creation is not easily corrected

Added by Justin Sherrill over 6 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Category:
Orchestration
Target version:
Difficulty:
hard
Triaged:
Yes
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

When trying to create a repository, if an error occurs due to some user error the dynflow process cannot be corrected.

For example:

Create a puppet repo with a feed url starting with 'https'

The repository creation process will start but the dynflow task will fail when it tries to create it in pulp. Since the user cannot re-submit the task and update the feed url, he is forced to go into the rails console and delete the repository.

Associated revisions

Revision 8c67ff53 (diff)
Added by Justin Sherrill over 6 years ago

fixes #5096 - fail gracefully on pulp repo creation failure

The goal is to run the action creation in the plan phase
and error out if its not valid. A similar approach is taken
with Content Host Creation. However in that case, content hosts
are not created in other situations. Repositories are created during
publish/promote of content views as well and in that situation we do not
want to perform pulp creation in the plan phase. As a result I have created
a new action CreateImmediate that does the creation in the plan phase.
It attempts to use as much from Create as possible (there is a lot of code there)

Revision 3344a17b
Added by Justin Sherrill over 6 years ago

Merge pull request #4456 from jlsherrill/5096

fixes #5096 - fail gracefully on pulp repo creation failure

History

#1 Updated by Eric Helms over 6 years ago

  • Assignee set to Justin Sherrill
  • Difficulty set to easy
  • Triaged changed from No to Yes

#2 Updated by Justin Sherrill over 6 years ago

New reproducer,

try to create a puppet repo with feed of:

ftp://hostname.com/path

#3 Updated by Justin Sherrill over 6 years ago

  • Difficulty changed from easy to hard

#4 Updated by Justin Sherrill over 6 years ago

  • Target version set to 49
  • Legacy Backlogs Release (now unused) set to 13

#5 Updated by Partha Aji over 6 years ago

  • Bugzilla link set to 1116954

#6 Updated by The Foreman Bot over 6 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/Katello/katello/pull/4456 added

#7 Updated by Justin Sherrill over 6 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF