Bug #5489: Permission migration script can create invalid search conditions - Foreman

Actions

Copy link

Bug #5489

closed

Permission migration script can create invalid search conditions

Added by Marek Hulán over 10 years ago. Updated over 6 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Dominic Cleal

Category:

Users, Roles and Permissions

Target version:

1.5.0

Difficulty:

Triaged:

Bugzilla link:

Pull request:

Fixed in Releases:

Found in Releases:

1.5.0

Red Hat JIRA:

Description

after migration a user reported filters with search phrases like "(() or (compute_resource_id = 2))" which raises scoped search exceptions, we should go over the whole migration script and make sure we can't detect empty conditions

Related issues 1 (1 open — 0 closed)

Actions

Copy link

Updated by Marek Hulán over 10 years ago

Blocks Tracker #4552: New permissions/authorization system issues added

Actions

Copy link

Updated by Marek Hulán over 10 years ago

one clue (but worth of checking all condition generating)

the only users who had the incorrect search string syntax were ones that had ownership of more than one hostgroup

Actions

Copy link

Updated by Dominic Cleal over 10 years ago

Target version set to 1.8.3
Translation missing: en.field_release set to 4

Actions

Copy link

Updated by Dominic Cleal over 10 years ago

Status changed from New to Assigned
Assignee set to Dominic Cleal

Actions

Copy link

Updated by Dominic Cleal over 10 years ago

To reproduce:

0. Use pre-#812 Foreman
1. Create a user with the "View hosts" role (#5540)
2. Edit the user, add two types of filter: a domain filter + a host group filter. Do not tick owned hosts.
3. Migrate to post-#812
4. Check the custom role + filter added, you'll see: (() or (domain_id = 1)) or (hostgroup_id = 1)