Project

General

Profile

Bug #6078

-1 should not be used to represent "unlimited" for activation keys and host collections

Added by Walden Raines about 5 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Web UI
Target version:
Difficulty:
Triaged:
Yes
Bugzilla link:
Pull request:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1105175
Description of problem:

Created a host-collection whose value was set to '10' for content-host limit. Later, I updated the limit with "-1", as soon as I type "-1", the text box closes and points to "unlimited" checkbox.

So -1 shouldn't be allowed for content host limit.

Version-Release number of selected component (if applicable):
sat6 beta snap8 (Satellite-6.0.3-RHEL-6-20140604.0)

How reproducible:
always

Steps to Reproduce:
1. create host collection with limit 10
2. update the limit with -1
3.

Actual results:
on updating the limit with -1, ticks the checkbox to unlimited

Expected results:
user shouldn't be allowed to set limit to -1

Additional info:
A related bz #848564


Related issues

Has duplicate Katello - Bug #6127: user shouldn't be allowed to update the content-host limit to -1 for selected host-colectionDuplicate2014-06-09

Associated revisions

Revision 607f4e7f (diff)
Added by Walden Raines about 5 years ago

Fixes #6078, #6300, #6514, BZ1105175, BZ1097054, BZ1101586: fix limit fields

This commit changes the way we handle limited fields such as Content Host
number of systems and Activation Key usage limit. Instead of representing
"unlimited" as -1 we now represent it as a boolean on the object.

http://projects.theforeman.org/issues/6078
http://projects.theforeman.org/issues/6300
http://projects.theforeman.org/issues/6514
https://bugzilla.redhat.com/show_bug.cgi?id=1105175
https://bugzilla.redhat.com/show_bug.cgi?id=1097054
https://bugzilla.redhat.com/show_bug.cgi?id=1101586

Revision 5b00bb70 (diff)
Added by Walden Raines about 5 years ago

Fixes #6078, #6300, #6514, BZ1105175, BZ1097054, BZ1101586: fix limit fields

This commit changes the way we handle limited fields such as Content Host
number of systems and Activation Key usage limit. Instead of representing
"unlimited" as -1 we now represent it as a boolean on the object.

http://projects.theforeman.org/issues/6078
http://projects.theforeman.org/issues/6300
http://projects.theforeman.org/issues/6514
https://bugzilla.redhat.com/show_bug.cgi?id=1105175
https://bugzilla.redhat.com/show_bug.cgi?id=1097054
https://bugzilla.redhat.com/show_bug.cgi?id=1101586

Revision 5f406a71
Added by Walden Raines about 5 years ago

Merge pull request #4360 from waldenraines/6300

Fixes #6078, #6300, #6514, BZ1105175, BZ1097054, BZ1101586: fix limit fields

Revision 7434b38a
Added by Walden Raines about 5 years ago

Merge pull request #4360 from waldenraines/6300

Fixes #6078, #6300, #6514, BZ1105175, BZ1097054, BZ1101586: fix limit fields

History

#1 Updated by Eric Helms about 5 years ago

  • Assignee set to Walden Raines
  • Target version set to 45
  • Triaged set to Yes

#2 Updated by Walden Raines about 5 years ago

  • Has duplicate Bug #6127: user shouldn't be allowed to update the content-host limit to -1 for selected host-colection added

#3 Updated by Eric Helms about 5 years ago

  • Target version deleted (45)

#4 Updated by Walden Raines about 5 years ago

  • Subject changed from user shouldn't be allowed to update the content-host limit to -1 for selected host-colection to -1 should not be used to represent "unlimited"
  • Priority changed from Low to Normal
  • Target version set to 49

Changing summary this to reflect system-wide nature of problem.

For both activation keys and host collections we should not use -1 to represent "unlimited". This issue captures the following work:

  • Fix the client side UI so that only > 1 limits can be sent
  • Fix the server side so that "unlimited" is represented as a boolean and that limit is ignored if true
  • Check that candlepin integration still works

#5 Updated by Walden Raines about 5 years ago

  • Subject changed from -1 should not be used to represent "unlimited" to -1 should not be used to represent "unlimited" for activation keys and host collections

#6 Updated by Walden Raines about 5 years ago

  • Status changed from New to Assigned

#7 Updated by Walden Raines about 5 years ago

  • Status changed from Assigned to Ready For Testing

#8 Updated by Walden Raines about 5 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#9 Updated by Eric Helms almost 5 years ago

  • Legacy Backlogs Release (now unused) set to 13

Also available in: Atom PDF