Project

General

Profile

Bug #6585

Fix command exit code handling under Ruby 1.9+

Added by Dominic Cleal over 8 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Aaron Stone
Category:
-
Target version:
1.6.0
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/smart-proxy/pull/181
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

The exit codes from executed commands aren't retrieved properly, this can be fixed for Ruby 1.9+.

Associated revisions

Revision bbafbc03 (diff)
Added by Aaron Stone over 8 years ago

fixes #6585 - Update Proxy::Util::CommandTask to handle Ruby 1.8 and 1.9+

In this update, use 'true' and 'false' to test $? return codes 0 and 1, respectively.
In Ruby 1.8.x, the return code from Open3.popen3 is always 0, some errors will not be caught.

History

#1 Updated by Aaron Stone over 8 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

#2 Updated by Dominic Cleal over 8 years ago

  • Assignee set to Aaron Stone

Also available in: Atom PDF