Bug #6585

Fix command exit code handling under Ruby 1.9+

Added by Dominic Cleal about 4 years ago. Updated 7 days ago.

Status:Closed
Priority:Normal
Assignee:Aaron Stone
Category:-
Target version:1.6.0
Difficulty: Team Backlog:
Triaged: Fixed in Releases:
Bugzilla link: Found in Releases:
Pull request:https://github.com/theforeman/smart-proxy/pull/181

Description

The exit codes from executed commands aren't retrieved properly, this can be fixed for Ruby 1.9+.

Associated revisions

Revision bbafbc03
Added by Aaron Stone about 4 years ago

fixes #6585 - Update Proxy::Util::CommandTask to handle Ruby 1.8 and 1.9+

In this update, use 'true' and 'false' to test $? return codes 0 and 1, respectively.
In Ruby 1.8.x, the return code from Open3.popen3 is always 0, some errors will not be caught.

History

#1 Updated by Aaron Stone about 4 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

#2 Updated by Dominic Cleal almost 4 years ago

  • Assignee set to Aaron Stone

Also available in: Atom PDF