Feature #8018

Repository creation (API/CLI/UI) should perform validation on name for Docker-based repositories

Added by Og Maciel over 3 years ago. Updated 9 days ago.

Status:Closed
Priority:Normal
Assignee:-
Category:Web UI
Target version:Katello 2.1
Difficulty: Team Backlog:
Triaged:Yes Fixed in Releases:
Bugzilla link: Found in Releases:
Pull request:https://github.com/Katello/katello/pull/4784

Description

Since the name for a Docker-based repository need to match the exact 'upstream name' for an existing Docker image, we will need to perform some type of sanitation in the name field so that only the expected characters (i.e. a-z, 0-9, / and _) are allowed. If we don't perform any validation for Docker-based repos, then the user won't find out about this until he/she tries to synchronize it.

If no form validation can be performed (UI), then perhaps we should display some type of help text explaining what the rules are? Preferably all layers (API, CLI and UI) would fail to create the repository and provide some useful information so that the user can fix the name.

Associated revisions

Revision fdb366cc
Added by Adam Ruzicka over 3 years ago

Fixes #8018 - Performs docker repository name validation on repo create

Revision 65ffcd2d
Added by David Davis over 3 years ago

Merge pull request #4784 from adamruzicka/docker-repo-validation

Fixes #8018 - Performs docker repository name validation on repo create

History

#1 Updated by The Foreman Bot over 3 years ago

  • Status changed from New to Ready For Testing
  • Target version set to 59
  • Pull request https://github.com/Katello/katello/pull/4784 added

#2 Updated by Eric Helms over 3 years ago

  • Target version changed from 59 to 61

#3 Updated by Adam Ruzicka over 3 years ago

It would be good to include the definition of docker repository name format in the docs.
The format is:

[USERNAME/]REPOSITORY where
USERNAME can contain lower case letters and digits, 4-30 characters (inclusive)
REPOSITORY can contain lower case letters, digits, dashes, underscores and dots, 3-30 characters (inclusive)

#4 Updated by Adam Ruzicka over 3 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#5 Updated by Eric Helms over 3 years ago

  • Legacy Backlogs Release (now unused) set to 14

Also available in: Atom PDF