Project

General

Profile

Bug #8228

default_template_url removed from API controllers, causes PXE menu build failure

Added by Dominic Cleal about 6 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Templates
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

#4463 removed default_template_url methods from the two API controllers, but left it in the UI controller. This method is called by PXE default templates, e.g.

ks=<%= default_template_url(profile[:template], profile[:hostgroup]) %>

https://github.com/theforeman/community-templates/blob/master/pxe/PXELinux_default.erb#L25

I see it's been fixed in the UI controller for the #4463 bug, but the code should have been moved somewhere common, not removed in 2/3 places.

failed to process template: undefined method `default_template_url' for #&lt;Api::V2::ConfigTemplatesController:0x0000000a0ada48&gt;

Related issues

Related to Foreman - Bug #4463: Default profiles templates default to https:// connection for kickstartClosed2014-02-26

Associated revisions

Revision 563fa283 (diff)
Added by Shlomi Zadok almost 6 years ago

fixes #8228 - add a config_templates concern to serve config_templates controllers

Revision 4c913331 (diff)
Added by Shlomi Zadok almost 6 years ago

fixes #8228 - add a config_templates concern to serve config_templates controllers

(cherry picked from commit 563fa283aff363801d5cd160ab0c54f6c7634d98)

History

#1 Updated by Dominic Cleal about 6 years ago

  • Related to Bug #4463: Default profiles templates default to https:// connection for kickstart added

#2 Updated by The Foreman Bot about 6 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/1913 added
  • Pull request deleted ()

#3 Updated by Shlomi Zadok about 6 years ago

  • Assignee set to Shlomi Zadok

#4 Updated by Shlomi Zadok almost 6 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#5 Updated by Dominic Cleal almost 6 years ago

  • Legacy Backlogs Release (now unused) changed from 28 to 29

Also available in: Atom PDF