Refactor #15037

Improve editable elements

Added by Amir Fefer 11 months ago. Updated 5 months ago.

Status:Closed
Priority:Normal
Assigned To:Amir Fefer
Category:Settings
Target version:-
Difficulty: Bugzilla link:
Found in release: Pull request:https://github.com/theforeman/foreman/pull/3523
Story points-
Velocity based estimate-
Release1.13.0Release relationshipAuto

Description

Foreman uses Jeditable jquery plugin for editable elements.
This plugin is unmaintained, and lack of some features.

A better alternative is x-editable, well maintained and supports much more inputs:

  • text
  • textarea
  • select
  • date
  • datetime
  • dateui
  • combodate
  • html5types
  • checklist
  • wysihtml5
  • typeahead
  • typeaheadjs
  • select2

Related issues

Related to Katello - Bug #15832: Red Hat Repositories page not loading Closed 07/25/2016
Related to Foreman - Bug #16075: Changing any setting fails: Invalid authenticity token Closed 08/11/2016

Associated revisions

Revision d1635077
Added by Amir Fefer 8 months ago

Fixes #15037 - Improves editable elements in settings

Revision 42917573
Added by Dominic Cleal 8 months ago

refs #15037 - require rubygem-x-editable-rails

History

#1 Updated by Amir Fefer 11 months ago

  • Category set to Settings

#2 Updated by The Foreman Bot 11 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3523 added

#3 Updated by Amir Fefer 8 months ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#4 Updated by Dominic Cleal 8 months ago

  • Release set to 1.13.0

#5 Updated by Andrew Kofink 8 months ago

  • Related to Bug #15832: Red Hat Repositories page not loading added

#6 Updated by Dominic Cleal 8 months ago

  • Related to Bug #16075: Changing any setting fails: Invalid authenticity token added

#7 Updated by Dominic Cleal 5 months ago

Please note that a stored XSS vulnerability has been identified in Foreman 1.11.0 to 1.12.4 identified as CVE-2016-8639 (details on https://theforeman.org/security.html soon) that has been fixed by this refactoring. It was originally introduced in #13721.

Also available in: Atom PDF