Project

General

Profile

Actions

Bug #5574

closed

CDN path verification should handle redirects

Added by Justin Sherrill almost 10 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
High
Assignee:
Category:
Orchestration
Target version:
Difficulty:
Triaged:
Yes
Fixed in Releases:
Found in Releases:

Description

Currently the cdn_var_substitutor#valid_substitutions? treats 301 redirects as an error. In some cases it will try to fetch $REPO_URL/repodata which causes a redirect to $REPO_URL/repodata/. One solution is to have it request $REPO_URL/repodata/repomd.xml, but i would argue it should just follow redirects as well.

Actions #1

Updated by Justin Sherrill almost 10 years ago

To temporarily patch the issue:

/opt/rh/ruby193/root/usr/share/gems/gems/katello-1.5.0/app/lib/katello/util/cdn_var_substitutor.rb

Line 116:

 Change:
        is_valid = valid_path?(real_path, 'repodata') || valid_path?(real_path, 'PULP_MANIFEST')
 To:

        is_valid = valid_path?(real_path, 'repodata/repomd.xml') || valid_path?(real_path, 'PULP_MANIFEST')

Actions #2

Updated by Mike McCune almost 10 years ago

  • Due date set to 05/22/2014
  • Assignee set to Mike McCune
  • Target version set to 44
  • Triaged changed from No to Yes
Actions #3

Updated by Ivan Necas almost 10 years ago

  • Status changed from New to Assigned
  • Assignee changed from Mike McCune to Ivan Necas
  • Bugzilla link set to https://bugzilla.redhat.com/show_bug.cgi?id=1099221
Actions #4

Updated by Ivan Necas almost 10 years ago

  • Status changed from Assigned to Ready For Testing
Actions #5

Updated by Ivan Necas almost 10 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Applied in changeset katello|commit:68149256f311f3426c60b7dc73f0f69dda96368a.

Actions #6

Updated by Eric Helms over 9 years ago

  • translation missing: en.field_release set to 13
Actions

Also available in: Atom PDF