Bug #11689
closed
Hidden value checkbox on global parameter form doesn't replace editor
Description
When editing a global parameter, the "Hidden value" checkbox doesn't replace the full editor (added in #11625) when checked, and the new textbox stays there when unchecked.
1. Edit a non-hidden parameter, check the "Hidden value" box and a new textbox appears between the editor toolbar and textarea. The old non-hidden value is still shown in the textarea.
2. Untick the "Hidden value" box and the new textbox remains.
3. Create a hidden parameter, untick the "Hidden value" box and the password field is replaced by a textbox and not the editor.
Files
| Screenshot from 2015-09-04 10-03-59.png | View Screenshot from 2015-09-04 10-03-59.png | 62 KB | bug 1 | ||
| Screenshot from 2015-09-04 10-04-07.png | View Screenshot from 2015-09-04 10-04-07.png | 63.1 KB | bug 2 |
Updated by Dominic Cleal over 8 years ago
- Related to Refactor #11625: Make foreman ace editor reusable added
Updated by Walden Raines over 8 years ago
- Status changed from New to Assigned
- Assignee set to Walden Raines
What's the expected behavior when the hidden value checkbox is checked?
It looks like it used to turn the text field into a password input which is grotesquely unsemantic and could even automatically be populated by a password via the browser or some plugin.
Does it really make sense to mask the input on the edit page? I understand not showing it on the list page but if you are going to edit a value, aren't you likely to want to see it?
Updated by Dominic Cleal over 8 years ago
Yes, the previous behaviour is the expected behaviour - to swap the text box for a password/hidden field and back.
Updated by Walden Raines over 8 years ago
Dominic Cleal wrote:
Yes, the previous behaviour is the expected behaviour - to swap the text box for a password/hidden field and back.
Okay, but I will mask the value using something other than a password field.
Updated by The Foreman Bot over 8 years ago
- Status changed from Assigned to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/2706 added
- Pull request deleted (
)
Updated by Walden Raines over 8 years ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset f92e7cc9b0e1d9e4feecef072ceb973a87222c46.
Updated by Tomer Brisker over 8 years ago
- Related to Bug #11845: Hiding and then unhiding a parameter value breaks on host[group] parameters added