Project

General

Profile

Bug #11812

Remove whiny nils and add eager load

Added by Daniel Lobato Garcia almost 4 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Category:
Rails
Target version:
Difficulty:
Triaged:
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

In Rails 4 whiny_nils are going to be removed. These are useless now that we don't support ruby 1.8.7.
Since config.eager_load is mandatory in Rails 4, I'll set it when we remove this in dev/test.


Related issues

Related to Foreman - Tracker #3157: Rails 4.1 upgrade tasksClosed2013-09-27

Associated revisions

Revision 480b571c (diff)
Added by Daniel Lobato Garcia almost 4 years ago

Fixes #11812 - Remove whiny nils and add eager load

In Rails 4 eager_load is mandatory, and whiny_nils are already useless
in Foreman as we don't support 1.8.7.

History

#1 Updated by Daniel Lobato Garcia almost 4 years ago

#2 Updated by The Foreman Bot almost 4 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2717 added
  • Pull request deleted ()

#3 Updated by Daniel Lobato Garcia almost 4 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#4 Updated by Ohad Levy almost 4 years ago

  • Legacy Backlogs Release (now unused) set to 63

#5 Updated by Dominic Cleal almost 4 years ago

  • Category set to Rails

Also available in: Atom PDF