Project

General

Profile

Bug #11844

Remove duplicate distinct scope in FactValue

Added by Daniel Lobato Garcia almost 4 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Category:
Rails
Target version:
Difficulty:
Triaged:
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

ActiveRecord 4.1.5 includes a class method distinct and we have to either rename or delete the distinct scope in FactValue on Rails 4. Since I didn't find any instance of it, I think we can just remove it.


Related issues

Related to Foreman - Tracker #3157: Rails 4.1 upgrade tasksClosed2013-09-27

Associated revisions

Revision 96b50275 (diff)
Added by Daniel Lobato Garcia almost 4 years ago

Fixes #11844 - Remove duplicate scope in FactValue

ActiveRecord 4.1.5 includes a class method distinct and we have to
either rename or delete the distinct scope in FactValue on Rails 4.
Since I didn't find any instance of it, I think we can just remove it.

History

#1 Updated by Daniel Lobato Garcia almost 4 years ago

#2 Updated by The Foreman Bot almost 4 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2727 added
  • Pull request deleted ()

#3 Updated by Daniel Lobato Garcia almost 4 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#4 Updated by Ohad Levy almost 4 years ago

  • Legacy Backlogs Release (now unused) set to 63

#5 Updated by Dominic Cleal almost 4 years ago

  • Category set to Rails
  • Assignee set to Daniel Lobato Garcia

Also available in: Atom PDF