Project

General

Profile

Actions

Bug #12097

closed

rails 4 compatibility - user_test compatible updates

Added by Tom Caspy over 8 years ago. Updated over 8 years ago.

Status:
Rejected
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Related issues 1 (0 open1 closed)

Related to Foreman - Tracker #3157: Rails 4.1 upgrade tasksClosed09/27/2013

Actions
Actions #1

Updated by The Foreman Bot over 8 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2795 added
  • Pull request deleted ()
Actions #2

Updated by Daniel Lobato Garcia over 8 years ago

Actions #3

Updated by Daniel Lobato Garcia over 8 years ago

in dhcp - reload in rails 4 does not nullify instance variables, so we use find to instantiate a completely different object, thus nullifying the variables.
in user_test - in real life we don't assign roles without a user existing, thus, in test we can assign after user created as well. UserRole presence validation on owner doesn't work in creation, as apparently polymorphic associations aren't populated on create, just after they're actually saved.

Actions #4

Updated by Tom Caspy over 8 years ago

  • Subject changed from rails 4 compatibility - user_test and dhcp_test compatible updates to rails 4 compatibility - user_test compatible updates
Actions #5

Updated by Dominic Cleal over 8 years ago

  • Status changed from Ready For Testing to Rejected

PR was closed and I think fixed differently in #12109.

Actions

Also available in: Atom PDF