Project

General

Profile

Bug #12097

rails 4 compatibility - user_test compatible updates

Added by Tom Caspy almost 6 years ago. Updated over 5 years ago.

Status:
Rejected
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Fixed in Releases:
Found in Releases:

Related issues

Related to Foreman - Tracker #3157: Rails 4.1 upgrade tasksClosed2013-09-27

History

#1 Updated by The Foreman Bot almost 6 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2795 added
  • Pull request deleted ()

#2 Updated by Daniel Lobato Garcia almost 6 years ago

#3 Updated by Daniel Lobato Garcia almost 6 years ago

in dhcp - reload in rails 4 does not nullify instance variables, so we use find to instantiate a completely different object, thus nullifying the variables.
in user_test - in real life we don't assign roles without a user existing, thus, in test we can assign after user created as well. UserRole presence validation on owner doesn't work in creation, as apparently polymorphic associations aren't populated on create, just after they're actually saved.

#4 Updated by Tom Caspy almost 6 years ago

  • Subject changed from rails 4 compatibility - user_test and dhcp_test compatible updates to rails 4 compatibility - user_test compatible updates

#5 Updated by Dominic Cleal over 5 years ago

  • Status changed from Ready For Testing to Rejected

PR was closed and I think fixed differently in #12109.

Also available in: Atom PDF