Actions
Bug #12097
closedrails 4 compatibility - user_test compatible updates
Status:
Rejected
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Updated by The Foreman Bot about 9 years ago
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/2795 added
- Pull request deleted (
)
Updated by Daniel Lobato Garcia about 9 years ago
- Related to Tracker #3157: Rails 4.1 upgrade tasks added
Updated by Daniel Lobato Garcia about 9 years ago
in dhcp - reload in rails 4 does not nullify instance variables, so we use find to instantiate a completely different object, thus nullifying the variables.
in user_test - in real life we don't assign roles without a user existing, thus, in test we can assign after user created as well. UserRole presence validation on owner doesn't work in creation, as apparently polymorphic associations aren't populated on create, just after they're actually saved.
Updated by Tom Caspy about 9 years ago
- Subject changed from rails 4 compatibility - user_test and dhcp_test compatible updates to rails 4 compatibility - user_test compatible updates
Updated by Dominic Cleal almost 9 years ago
- Status changed from Ready For Testing to Rejected
PR was closed and I think fixed differently in #12109.
Actions