Project

General

Custom queries

Profile

Actions
Copy link

Refactor #12099

closed

Template locked? relying on rake makes tests fail

Added by Daniel Lobato Garcia over 9 years ago. Updated almost 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Daniel Lobato Garcia
Category:
Rails
Target version:
1.11.0
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/2834
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

app/models/template.rb has a method locked? that relies on !Foreman.in_rake? to bypass the locked validation when running some operations through Rake such as migrations or cloning templates. On Rails 4 rake test is also interpreted as being 'in rake' and tests fail when running them through rake test but not when running template tests individually.

Related issues 1 (0 open — 1 closed)

Related to Foreman - Tracker #3157: Rails 4.1 upgrade tasksClosed09/27/2013

Actions
Actions
Copy link
 #3

Updated by Dominic Cleal over 9 years ago

  • Status changed from Ready For Testing to Rejected

PR closed.

Actions
Copy link
 #4

Updated by Dominic Cleal over 9 years ago

  • Status changed from Rejected to Ready For Testing
  • Assignee set to Daniel Lobato Garcia
  • Pull request https://github.com/theforeman/foreman/pull/2834 added
  • Pull request deleted (https://github.com/theforeman/foreman/pull/2797)

New PR opened.

Actions
Copy link
 #6

Updated by Daniel Lobato Garcia over 9 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions
Copy link

Also available in: Atom PDF