Project

General

Profile

Actions
Copy link

Refactor #12180

closed

Move lookup_value presence validation to PuppetclassLookupKey

Added by Amir Fefer about 9 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Amir Fefer
Category:
Parameters
Target version:
1.11.0
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/2909
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

Global parameters can have empty values so smart variables that are also global should be allowed to accept empty values too.
The validation on lookup_value to make sure it isn't empty is in the LookupKey class therefore affecting both VariableLookupKey and PuppetClassLookupKey.
This validation should be moved to the child class - PuppetClassLookupKey.

Actions
Copy link
 #1

Updated by Amir Fefer about 9 years ago

  • Subject changed from Move lookup_value presence validation to PuppetclassLookupValue to Move lookup_value presence validation to PuppetclassLookupKey
Actions
Copy link
 #2

Updated by The Foreman Bot about 9 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2909 added
Actions
Copy link
 #3

Updated by Amir Fefer about 9 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions
Copy link
 #4

Updated by Dominic Cleal about 9 years ago

  • Translation missing: en.field_release set to 71
Actions
Copy link

Also available in: Atom PDF