Project

General

Profile

Actions

Bug #12672

closed

katello_url_helper ruby 2.2.2 compatible

Added by Chris Peters over 8 years ago. Updated over 5 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

When running the specs for models/provider_spec.rb with ruby 2.2.2 there is a test failure.

it "'https://'" do
@provider.repository_url = "https://"
@provider.wont_be :valid?
end

ruby 2.0 and 2.1 throw an exception when parsing the url "https://". This exception is caught and the method returns false. The intended behavior.

ruby 2.2.2 there is no exception thrown and thus the url is considered valid. This is not the intended behavior.


Related issues 1 (0 open1 closed)

Has duplicate Katello - Bug #12564: URI does not downcase scheme in Rails 4DuplicateDaniel Lobato Garcia11/23/2015Actions
Actions #1

Updated by The Foreman Bot over 8 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/Katello/katello/pull/5640 added
Actions #2

Updated by Eric Helms over 8 years ago

  • translation missing: en.field_release set to 86
  • Triaged changed from No to Yes
Actions #3

Updated by Eric Helms over 8 years ago

  • Has duplicate Bug #12564: URI does not downcase scheme in Rails 4 added
Actions #4

Updated by Eric Helms almost 8 years ago

  • Status changed from Ready For Testing to Resolved
Actions

Also available in: Atom PDF