Project

General

Profile

Bug #13741

Parameter with multiline value gets corrupted when set as hidden

Added by Marek Hulán almost 5 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Web Interface
Target version:
Difficulty:
Triaged:
Bugzilla link:

Description

To reproduce,

1. add a new parameter (e.g. global) with multiline value like
"-----BEGIN RSA PRIVATE KEY-----
....
...."
2. check hidden check box
3. uncheck it and see that all "\n" are gone

I suppose that's because a password field is used. I think original implementation handled this properly.


Related issues

Related to Foreman - Bug #12938: Hiding a smart variable causes the value field to be filled by autofill with the user's passwordResolved2015-12-24

Associated revisions

Revision 1dc0f39b (diff)
Added by Tomer Brisker over 4 years ago

Fixes #13741 - Prevent hidden parameters from erasing newline

Switching the input from textarea to password leads to all newline
characters being stripped from the value. This PR attempts to prevent
this by changing the font of the textarea to a font that displays a
bullet instead of every character, thereby preventing the need to
change the input into a password field.

Revision ddf1410e (diff)
Added by Tomer Brisker over 4 years ago

Refs #13741 - Hidden values use masked input for default value

This was missed in the pervious commit. Opening a hidden lookup key led
to the default value being displayed using a password input instead of
as a masked text area.

History

#1 Updated by Ori Rabin over 4 years ago

  • Status changed from New to Assigned
  • Assignee set to Ori Rabin

#2 Updated by The Foreman Bot over 4 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3485 added

#3 Updated by Ori Rabin over 4 years ago

  • Status changed from Ready For Testing to Assigned
  • Pull request deleted (https://github.com/theforeman/foreman/pull/3485)

#4 Updated by The Foreman Bot over 4 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3492 added

#5 Updated by Ori Rabin over 4 years ago

  • Assignee changed from Ori Rabin to Tomer Brisker

#6 Updated by Marek Hulán over 4 years ago

  • Legacy Backlogs Release (now unused) set to 136

#7 Updated by Anonymous over 4 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#8 Updated by Tomer Brisker over 4 years ago

  • Related to Bug #12938: Hiding a smart variable causes the value field to be filled by autofill with the user's password added

#9 Updated by The Foreman Bot over 4 years ago

  • Pull request https://github.com/theforeman/foreman/pull/3541 added

Also available in: Atom PDF