Project

General

Profile

Bug #13769

SSH provisioning fails when sql logging level is set to 'error'

Added by Ivan Necas about 7 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Ivan Necas
Category:
Orchestration
Target version:
1.14.2
Difficulty:
Triaged:
Bugzilla link:
1325939
Pull request:
https://github.com/theforeman/foreman/pull/4262
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

Current logger calls return `true`|`false` depending whether the current level
allows the logging message or not.

In the orchestration, we happened to have the logger call as the last
call of the orchestration method (https://github.com/theforeman/foreman/blob/1.10.1/app/models/concerns/orchestration/ssh_provision.rb#L66).

When the method returns non-true value, it's considered as failure and the whole thing
tries to get rollbacked.

Related issues

Related to Foreman - Bug #13771: Failure in after_commit orchestration is very hard to debugNew2016-02-17
Related to Foreman - Tracker #14002: Orchestration build around ActiveRecord hooks trackerNew2016-03-02

Related to Foreman - Bug #14004: After_commit failure doesn't handle the rollback for the actions performed from the pre_commit phase and active record objectsNew2016-03-02

Associated revisions

Revision a4e1e08c (diff)
Added by Ivan Necas about 6 years ago

Fixes #3541,#13769 - return true on success of ssh orchestration

Strange things start happening otherwise.

Revision 20134e11 (diff)
Added by Ivan Necas about 6 years ago

Fixes #3541,#13769 - return true on success of ssh orchestration

Strange things start happening otherwise.

(cherry picked from commit a4e1e08ceb388e9749fceee8ae4487ab3c76c105)

History

#1 Updated by Ivan Necas about 7 years ago

  • Related to Bug #13771: Failure in after_commit orchestration is very hard to debug added

#2 Updated by Ivan Necas about 7 years ago

  • Related to Tracker #14002: Orchestration build around ActiveRecord hooks tracker added

#3 Updated by Ivan Necas about 7 years ago

  • Related to Bug #14004: After_commit failure doesn't handle the rollback for the actions performed from the pre_commit phase and active record objects added

#4 Updated by The Foreman Bot about 7 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Ivan Necas
  • Pull request https://github.com/theforeman/foreman/pull/3269 added

#5 Updated by Bryan Kearney almost 7 years ago

  • Bugzilla link set to 1325939

#6 Updated by Dominic Cleal over 6 years ago

  • Status changed from Ready For Testing to New
  • Assignee deleted (Ivan Necas)
  • Pull request deleted (https://github.com/theforeman/foreman/pull/3269)

Issue likely still present, but PR closed due to inactivity.

#7 Updated by The Foreman Bot about 6 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Ivan Necas
  • Pull request https://github.com/theforeman/foreman/pull/4262 added

#8 Updated by Ivan Necas about 6 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#9 Updated by Dominic Cleal about 6 years ago

  • Legacy Backlogs Release (now unused) set to 221

Also available in: Atom PDF