Project

General

Profile

Actions

Bug #13769

closed

SSH provisioning fails when sql logging level is set to 'error'

Added by Ivan Necas almost 9 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Orchestration
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

Current logger calls return `true`|`false` depending whether the current level
allows the logging message or not.

In the orchestration, we happened to have the logger call as the last
call of the orchestration method (https://github.com/theforeman/foreman/blob/1.10.1/app/models/concerns/orchestration/ssh_provision.rb#L66).

When the method returns non-true value, it's considered as failure and the whole thing
tries to get rollbacked.


Related issues 3 (3 open0 closed)

Related to Foreman - Bug #13771: Failure in after_commit orchestration is very hard to debugNew02/17/2016Actions
Related to Foreman - Tracker #14002: Orchestration build around ActiveRecord hooks trackerNew03/02/2016

Actions
Related to Foreman - Bug #14004: After_commit failure doesn't handle the rollback for the actions performed from the pre_commit phase and active record objectsNew03/02/2016Actions
Actions #1

Updated by Ivan Necas almost 9 years ago

  • Related to Bug #13771: Failure in after_commit orchestration is very hard to debug added
Actions #2

Updated by Ivan Necas almost 9 years ago

  • Related to Tracker #14002: Orchestration build around ActiveRecord hooks tracker added
Actions #3

Updated by Ivan Necas almost 9 years ago

  • Related to Bug #14004: After_commit failure doesn't handle the rollback for the actions performed from the pre_commit phase and active record objects added
Actions #4

Updated by The Foreman Bot almost 9 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Ivan Necas
  • Pull request https://github.com/theforeman/foreman/pull/3269 added
Actions #5

Updated by Bryan Kearney over 8 years ago

  • Bugzilla link set to 1325939
Actions #6

Updated by Dominic Cleal about 8 years ago

  • Status changed from Ready For Testing to New
  • Assignee deleted (Ivan Necas)
  • Pull request deleted (https://github.com/theforeman/foreman/pull/3269)

Issue likely still present, but PR closed due to inactivity.

Actions #7

Updated by The Foreman Bot almost 8 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Ivan Necas
  • Pull request https://github.com/theforeman/foreman/pull/4262 added
Actions #8

Updated by Ivan Necas almost 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #9

Updated by Dominic Cleal almost 8 years ago

  • Translation missing: en.field_release set to 221
Actions

Also available in: Atom PDF