Bug #13968
Show errors when creating proxy even if /features returns an array
Description
When using an old version of Foreman, say '1.10' against a newer version of the proxy, say one that contains the 'logs' feature, the /features call will return an array ['logs'].
If you try to add a smart-proxy that only has this feature, the check we make `reply.is_a?(Array) and reply.any?` is not enough. We should verify we have the features in the db.
Currently the problem is:
- I try to add new smart-proxy with features ['logs'] to old foreman without this feature.
- Submit, it won't save. But it won't throw any error either.
We should display an error and say 'the features in this proxy are not recognized by foreman'.
Related issues
Associated revisions
refs #13968 - use existing feature to ensure reliable comparison
Feature.name_map may have returned either the new factory-based feature
or the existing fixture-based feature for the name 'TFTP', causing
intermittent failures.
History
#1
Updated by The Foreman Bot about 6 years ago
- Status changed from New to Ready For Testing
- Assignee set to Daniel Lobato Garcia
- Pull request https://github.com/theforeman/foreman/pull/3270 added
#2
Updated by Dominic Cleal about 6 years ago
- Has duplicate Feature #14669: Show something like "No supported features available on proxy" instead of quietly do nothing and just write in log "Failed to save" added
#3
Updated by Dominic Cleal over 5 years ago
- Status changed from Ready For Testing to New
- Assignee deleted (
Daniel Lobato Garcia) - Pull request deleted (
https://github.com/theforeman/foreman/pull/3270)
PR closed due to inactivity, but the bug is probably still valid.
#4
Updated by The Foreman Bot over 5 years ago
- Status changed from New to Ready For Testing
- Assignee set to Shlomi Zadok
- Pull request https://github.com/theforeman/foreman/pull/3895 added
#5
Updated by Shlomi Zadok over 5 years ago
- Target version set to 1.5.3
#6
Updated by Marek Hulán over 5 years ago
- Target version changed from 1.5.3 to 1.5.0
#7
Updated by The Foreman Bot over 5 years ago
- Pull request https://github.com/Katello/katello/pull/6377 added
#8
Updated by Shlomi Zadok over 5 years ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset 61802878d0d8a6b1bf2c6dfca8bfebdc7a8dc7bf.
#9
Updated by Dominic Cleal over 5 years ago
- Legacy Backlogs Release (now unused) set to 189
#10
Updated by The Foreman Bot over 5 years ago
- Pull request https://github.com/theforeman/foreman/pull/3946 added
Fixes #13968 - Add error when no known proxy features found