Project

General

Profile

Actions

Bug #13968

closed

Show errors when creating proxy even if /features returns an array

Added by Daniel Lobato Garcia over 8 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Smart Proxy
Target version:
Fixed in Releases:
Found in Releases:

Description

When using an old version of Foreman, say '1.10' against a newer version of the proxy, say one that contains the 'logs' feature, the /features call will return an array ['logs'].
If you try to add a smart-proxy that only has this feature, the check we make `reply.is_a?(Array) and reply.any?` is not enough. We should verify we have the features in the db.

Currently the problem is:

- I try to add new smart-proxy with features ['logs'] to old foreman without this feature.
- Submit, it won't save. But it won't throw any error either.

We should display an error and say 'the features in this proxy are not recognized by foreman'.


Related issues 1 (0 open1 closed)

Has duplicate Salt - Feature #14669: Show something like "No supported features available on proxy" instead of quietly do nothing and just write in log "Failed to save"Duplicate04/15/2016Actions
Actions #1

Updated by The Foreman Bot over 8 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Daniel Lobato Garcia
  • Pull request https://github.com/theforeman/foreman/pull/3270 added
Actions #2

Updated by Dominic Cleal about 8 years ago

  • Has duplicate Feature #14669: Show something like "No supported features available on proxy" instead of quietly do nothing and just write in log "Failed to save" added
Actions #3

Updated by Dominic Cleal almost 8 years ago

  • Status changed from Ready For Testing to New
  • Assignee deleted (Daniel Lobato Garcia)
  • Pull request deleted (https://github.com/theforeman/foreman/pull/3270)

PR closed due to inactivity, but the bug is probably still valid.

Actions #4

Updated by The Foreman Bot almost 8 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Shlomi Zadok
  • Pull request https://github.com/theforeman/foreman/pull/3895 added
Actions #5

Updated by Shlomi Zadok almost 8 years ago

  • Target version set to 1.5.3
Actions #6

Updated by Marek Hulán almost 8 years ago

  • Target version changed from 1.5.3 to 1.5.0
Actions #7

Updated by The Foreman Bot almost 8 years ago

  • Pull request https://github.com/Katello/katello/pull/6377 added
Actions #8

Updated by Shlomi Zadok almost 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #9

Updated by Dominic Cleal almost 8 years ago

  • Translation missing: en.field_release set to 189
Actions #10

Updated by The Foreman Bot over 7 years ago

  • Pull request https://github.com/theforeman/foreman/pull/3946 added
Actions

Also available in: Atom PDF