Project

General

Profile

Bug #14221

Plugin asset compilation does not expand SCSS imports of CSS files

Added by Eric Helms almost 4 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Plugins-Engines
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

The plugin asset rake task is not using the template provided by sass-rails that correctly identifies css imports in SCSS files. This results in either compiled CSS files that have regular css import statements or can throw errors during asset compilation. In the former case, 404s will be seen in the browser in production because the stylesheet will try to import those CSS files from the server (when they should be embedded in the compiled CSS file).


Related issues

Blocks Katello - Bug #14163: Routing errors due to missing .css files on navigating sync status pageClosed2016-03-11

Associated revisions

Revision d8520a15 (diff)
Added by Eric Helms almost 4 years ago

Fixes #14221: Use Sass Rails template when compiling plugin assets

The Sass::Rails::Template is needed to resolve css files imported
in an SCSS file without setting them to css imports which lead
to 404s in production.

Revision 153cbdf3 (diff)
Added by Eric Helms almost 4 years ago

Fixes #14221: Use Sass Rails template when compiling plugin assets

The Sass::Rails::Template is needed to resolve css files imported
in an SCSS file without setting them to css imports which lead
to 404s in production.

(cherry picked from commit d8520a15230d854e65bb7de012a1a7e4f9806392)

History

#1 Updated by Eric Helms almost 4 years ago

  • Blocks Bug #14163: Routing errors due to missing .css files on navigating sync status page added

#2 Updated by The Foreman Bot almost 4 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3330 added

#3 Updated by Eric Helms almost 4 years ago

  • Bugzilla link set to 1318041

#4 Updated by Eric Helms almost 4 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#5 Updated by Dominic Cleal almost 4 years ago

  • Legacy Backlogs Release (now unused) set to 141

Also available in: Atom PDF