Refactor #14319
closed
Remove media_path template helper which is no longer used
Added by Marek Hulán almost 9 years ago.
Updated over 6 years ago.
Description
I haven't find any use of it among community-templates. I think it would be fair to mark as deprecated though. If this could get into 1.11 (as very small change) we'd get one cycle of deprecation warnings.
- Status changed from New to Assigned
So, I realized that media_path is actually unreachable when rendering the template. That's because when you call media_path, it uses rails route helpers and gives you '/media' as result. Therefore I don't see much benefit of adding deprecation warning there, someone could still use this helpers directly from plugin but since it's usecase is for templates rendering I think it's very unlikely. Also it could be easily reverted if needed. Thus I'll simply remove it.
- Status changed from Assigned to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/3359 added
- Related to Bug #9782: Using media_path in Templates does not resolve properly added
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
- Translation missing: en.field_release set to 136
Also available in: Atom
PDF