Project

General

Profile

Bug #14340

Icons loading causes intermittent issues in integration tests (especially under heavier load of the test machine)

Added by Ivan Necas about 6 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Tests
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

While debugging #13293, I've noticed, that it can take a while to load icons, when the machine
is under load. This can potentially lead to layout change (see the screenshots), that leads
https://github.com/teampoltergeist/poltergeist#mouseeventfailed-errors.

Debugging notes:

The issue is pretty hard to debug. Here are some hints to get some additional
tricks that can help to detect the issue:

I've used this snippet so see and compare how the page
looks right before the click event should happen

20.times do
  visit edit_host_path(host)
  assert page.has_link?('Parameters', :href => '#params')
  click_link 'Parameters'
  save_screenshot
end

Another good thing was looking into output of the `click` method
(it returns the coordinates that were clicked). Tracking that
for a while showed this:

2016-03-23T19:14:37 [app] [D] ====== click: {"position"=>{"x"=>851, "y"=>385}}
2016-03-23T19:15:20 [app] [D] ====== click: {"position"=>{"x"=>851, "y"=>385}}
2016-03-23T19:15:48 [app] [D] ====== click: {"position"=>{"x"=>851, "y"=>365}}

The coordinates of the event when the failure happened were different to the usual
values, which was a good indication that something is wrong with the layout.

Also, running it inside VM with 2GB of RAM and running 2 more tests suites in parallel
to simulate the load in Jenkins helped to reproduce the issue.

without-icons.png View without-icons.png 42.8 KB Layout when the icons are not loaded yet Ivan Necas, 03/24/2016 05:16 AM
with-icons.png View with-icons.png 44.6 KB Layout after the icons are loaded - the position of the remove button changes Ivan Necas, 03/24/2016 05:16 AM
Without icons With icons

Related issues

Related to Foreman - Bug #13293: Intermittent host#edit parameter integration test failures after timeoutResolved2016-01-20

Associated revisions

Revision f69b2276 (diff)
Added by Ivan Necas about 6 years ago

Fixes #14340 - specify the default icon sizes to prevent intermittent layout changes

History

#1 Updated by Ivan Necas about 6 years ago

  • Related to Bug #13293: Intermittent host#edit parameter integration test failures after timeout added

#2 Updated by Marek Hulán about 6 years ago

  • Category set to Tests

#4 Updated by Ivan Necas about 6 years ago

  • Status changed from New to Assigned

#5 Updated by The Foreman Bot about 6 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3364 added

#6 Updated by Ivan Necas about 6 years ago

  • Description updated (diff)

#7 Updated by Ivan Necas about 6 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#8 Updated by Dominic Cleal about 6 years ago

  • Legacy Backlogs Release (now unused) set to 136

Also available in: Atom PDF