Bug #14843
foreman-rake config should print errors when providing an invalid value
Description
Currently, foreman-rake config might take values for any setting, but when we check if it's valid or not, we just don't print the error when it's not valid.
https://github.com/theforeman/foreman/blob/develop/lib/tasks/config.rake#L111
Related issues
Associated revisions
History
#1
Updated by Dominic Cleal over 4 years ago
Updated by - Category set to Settings
#2
Updated by The Foreman Bot over 4 years ago
Updated by - Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/3470 added
#3
Updated by Daniel Lobato Garcia over 4 years ago
Updated by - Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset 5b53236fcc3acf0af29a2ddb60d17590d8db757f.
#4
Updated by Dominic Cleal over 4 years ago
- Legacy Backlogs Release (now unused) set to 136
#5
Updated by Dominic Cleal over 4 years ago
- Related to Bug #14898: Failure when running rake config added
Fixes #14843 - Improve rake config error handling
Currently rake config doesn't give you any hint when you provide an
invalid setting. Instead, it should tell you what was wrong with the
input, and try to guide you to a valid one.
This commit provides error handling for wrong JSON values, and prints
what the error was if the setting could not be saved.