Project

General

Profile

Bug #14843

foreman-rake config should print errors when providing an invalid value

Added by Daniel Lobato Garcia over 4 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Category:
Settings
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

Currently, foreman-rake config might take values for any setting, but when we check if it's valid or not, we just don't print the error when it's not valid.
https://github.com/theforeman/foreman/blob/develop/lib/tasks/config.rake#L111


Related issues

Related to Foreman - Bug #14898: Failure when running rake configClosed2016-05-02

Associated revisions

Revision 5b53236f (diff)
Added by Daniel Lobato Garcia over 4 years ago

Fixes #14843 - Improve rake config error handling

Currently rake config doesn't give you any hint when you provide an
invalid setting. Instead, it should tell you what was wrong with the
input, and try to guide you to a valid one.

This commit provides error handling for wrong JSON values, and prints
what the error was if the setting could not be saved.

History

#1 Updated by Dominic Cleal over 4 years ago

  • Category set to Settings

#2 Updated by The Foreman Bot over 4 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3470 added

#3 Updated by Daniel Lobato Garcia over 4 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#4 Updated by Dominic Cleal over 4 years ago

  • Legacy Backlogs Release (now unused) set to 136

#5 Updated by Dominic Cleal over 4 years ago

  • Related to Bug #14898: Failure when running rake config added

Also available in: Atom PDF