Foreman » Installer

I was helping to debug this on IRC - it seems that

• the Apache server is still up but serving Service Unavailable, so we're not hitting the timeout
• line 199 is consuming the real error code and raising RuntimeError instead

We should probably rewrite line 199 to pass the real error type up the stack and then add Net::HTTPServiceUnavailable to the list of rescues on line 347

I applied this PR to our puppet masters. At this point we have apache up but requests to it are timing out and node.rb now returns

 Could not send facts to Foreman: Net::ReadTimeout

And when Apache is stopped, we receive the following, again ignoring the cache:

Error retrieving node node.example.com: Net::HTTPServiceUnavailableCheck Foreman's /var/log/foreman/production.log for more information.

I can make it capture that Timeout error easily, I think we should rescue Timeout::Error instead, which is the parent exception of TimeoutError and ReadTimeout (and other timeouts).

The second error is kind of confusing though, as `res.code` should be 503 for Net::HTTPServiceUnavailable, which we should capture and raise here https://github.com/theforeman/puppet-foreman/pull/460/files#diff-56980159eb7873d008e28343dd19c1f3R201