Project

General

Profile

Refactor #15573

Support rest-client 2.0.0

Added by Dominic Cleal almost 5 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Dominic Cleal
Category:
Packaging
Target version:
1.13.0
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman-packaging/pull/1704, https://github.com/theforeman/foreman/pull/3620
Fixed in Releases:
Found in Releases:

Description

The Gemfile since #13698 limits Foreman to rest-client ~> 1.8.0, but 2.0.0 should be compatible and work fine, with the exception of tests which need changes to construct fake responses. The dependency should be relaxed to permit 2.x.

Related issues

Related to Foreman - Bug #27681: rest-client 2.1.0 breaks testsClosed

Associated revisions

Revision 6e7af6fc (diff)
Added by Dominic Cleal almost 5 years ago

fixes #15573 - support rest-client 2.x

Add a test helper that understands how to create fake responses for both
supported 1.8 and 2.x versions.

Revision 367ec758 (diff)
Added by Dominic Cleal about 4 years ago

refs #15573 - permit rest-client 2.x

History

#1 Updated by The Foreman Bot almost 5 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3620 added

#2 Updated by Dominic Cleal almost 5 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#3 Updated by Dominic Cleal almost 5 years ago

  • Legacy Backlogs Release (now unused) set to 160

#4 Updated by The Foreman Bot almost 4 years ago

  • Pull request https://github.com/theforeman/foreman-packaging/pull/1704 added

#5 Updated by Tomer Brisker almost 2 years ago

  • Related to Bug #27681: rest-client 2.1.0 breaks tests added

Also available in: Atom PDF