Project

General

Profile

Bug #15712

rabl 0.13.0 breaks ruby 2.0 support

Added by David Davis about 3 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Packaging
Target version:
Difficulty:
Triaged:
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

Opened an issue against rabl:

https://github.com/nesquena/rabl/issues/669

Here's the full error in Jenkins:

18:27:57 rake aborted!
18:27:57 SyntaxError: /usr/local/rvm/gems/ruby-2.0.0-p353@test_develop_pr_core-2/gems/rabl-0.13.0/lib/rabl/digestor.rb:6: syntax error, unexpected ','
18:27:57       def self.digest(name:, finder:, **options)
18:27:57                             ^
18:27:57 /usr/local/rvm/gems/ruby-2.0.0-p353@test_develop_pr_core-2/gems/rabl-0.13.0/lib/rabl/digestor.rb:31: syntax error, unexpected keyword_elsif, expecting keyword_end
18:27:57     elsif Gem::Version.new(Rails.version) >= Gem::Version.new('4.1')
18:27:57          ^
18:27:57 /usr/local/rvm/gems/ruby-2.0.0-p353@test_develop_pr_core-2/gems/rabl-0.13.0/lib/rabl/digestor.rb:60: syntax error, unexpected keyword_end, expecting end-of-input
18:27:57 /usr/local/rvm/gems/ruby-2.0.0-p353@test_develop_pr_core-2/gems/activesupport-4.2.6/lib/active_support/dependencies.rb:274:in `require'
18:27:57 /usr/local/rvm/gems/ruby-2.0.0-p353@test_develop_pr_core-2/gems/activesupport-4.2.6/lib/active_support/dependencies.rb:274:in `block in require'
18:27:57 /usr/local/rvm/gems/ruby-2.0.0-p353@test_develop_pr_core-2/gems/activesupport-4.2.6/lib/active_support/dependencies.rb:240:in `load_dependency'
18:27:57 /usr/local/rvm/gems/ruby-2.0.0-p353@test_develop_pr_core-2/gems/activesupport-4.2.6/lib/active_support/dependencies.rb:274:in `require'
18:27:57 /usr/local/rvm/gems/ruby-2.0.0-p353@test_develop_pr_core-2/gems/rabl-0.13.0/lib/rabl.rb:21:in `<top (required)>'
18:27:57 /usr/local/rvm/gems/ruby-2.0.0-p353@test_develop_pr_core-2/gems/bundler-1.12.5/lib/bundler/runtime.rb:86:in `require'
18:27:57 /usr/local/rvm/gems/ruby-2.0.0-p353@test_develop_pr_core-2/gems/bundler-1.12.5/lib/bundler/runtime.rb:86:in `block (2 levels) in require'
18:27:57 /usr/local/rvm/gems/ruby-2.0.0-p353@test_develop_pr_core-2/gems/bundler-1.12.5/lib/bundler/runtime.rb:81:in `each'
18:27:57 /usr/local/rvm/gems/ruby-2.0.0-p353@test_develop_pr_core-2/gems/bundler-1.12.5/lib/bundler/runtime.rb:81:in `block in require'
18:27:57 /usr/local/rvm/gems/ruby-2.0.0-p353@test_develop_pr_core-2/gems/bundler-1.12.5/lib/bundler/runtime.rb:70:in `each'
18:27:57 /usr/local/rvm/gems/ruby-2.0.0-p353@test_develop_pr_core-2/gems/bundler-1.12.5/lib/bundler/runtime.rb:70:in `require'
18:27:57 /usr/local/rvm/gems/ruby-2.0.0-p353@test_develop_pr_core-2/gems/bundler-1.12.5/lib/bundler.rb:102:in `require'
18:27:57 /var/lib/workspace/workspace/test_develop_pr_core/database/mysql/label/fast/ruby/2.0.0/config/application.rb:36:in `<top (required)>'
18:27:57 /var/lib/workspace/workspace/test_develop_pr_core/database/mysql/label/fast/ruby/2.0.0/Rakefile:1:in `require'
18:27:57 /var/lib/workspace/workspace/test_develop_pr_core/database/mysql/label/fast/ruby/2.0.0/Rakefile:1:in `<top (required)>'
18:27:57 /usr/local/rvm/gems/ruby-2.0.0-p353@test_develop_pr_core-2/gems/rake-11.2.2/exe/rake:27:in `<top (required)>'
18:27:57 /usr/local/rvm/gems/ruby-2.0.0-p353@test_develop_pr_core-2/bin/ruby_executable_hooks:15:in `eval'
18:27:57 /usr/local/rvm/gems/ruby-2.0.0-p353@test_develop_pr_core-2/bin/ruby_executable_hooks:15:in `<main>'
18:27:57 (See full trace by running task with --trace)

Related issues

Related to Foreman - Refactor #17070: Unpin rabl for 0.13.1Closed2016-10-24

Associated revisions

Revision 5f54b3b1 (diff)
Added by David Davis about 3 years ago

Fixes #15712 - Pinning rabl to less than 0.13

Revision 2d8f83ca (diff)
Added by David Davis about 3 years ago

Fixes #15712 - Pinning rabl to less than 0.13

(cherry picked from commit 5f54b3b17a69f174647d1b3eeb7ea3caae8cb1c1)

Revision bbc1c0c4 (diff)
Added by David Davis about 3 years ago

Fixes #15712 - Pinning rabl to less than 0.13

(cherry picked from commit 5f54b3b17a69f174647d1b3eeb7ea3caae8cb1c1)

History

#1 Updated by The Foreman Bot about 3 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3654 added

#2 Updated by David Davis about 3 years ago

  • Status changed from Ready For Testing to Rejected

#3 Updated by Dominic Cleal about 3 years ago

  • Category set to Packaging
  • Status changed from Rejected to Ready For Testing
  • Legacy Backlogs Release (now unused) set to 169

#4 Updated by David Davis about 3 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#5 Updated by Brandon Weeks about 3 years ago

Shouldn't this also go into 1.12.1?

#6 Updated by Dominic Cleal about 3 years ago

Brandon Weeks wrote:

Shouldn't this also go into 1.12.1?

Yes, it will, this is just the oldest release it'll be added to. The release field only works for one release, but when doing 1.12.1 I'll include anything in the older release too.

#7 Updated by Tomer Brisker about 3 years ago

#8 Updated by Dominic Cleal almost 3 years ago

#9 Updated by Dominic Cleal over 2 years ago

Also available in: Atom PDF