Project

General

Profile

Bug #15903

help displays currently configured settings as 'default'

Added by Stephen Benjamin about 3 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Difficulty:
Triaged:
No
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1124327
Description of problem:

When running `katello-installer --help` after installing or changing settings, katello-installer displays the currently configured values as 'default'. The effect of this is that the end-user will see differing values as 'default' depending on how their Satellite installation is configured. This behavior has the potential of confusing the end-user.

Version-Release number of selected component (if applicable):

How reproducible:
100%

Steps to Reproduce:
1. Install Satellite with default configuration (e.g. run katello-installer with no additional options)
2. Note the configuration of a feature (e.g. katello-installer --help | grep tftp) shows:
--capsule-tftp Use TFTP (default: false)

3. Enable the TFTP proxy (katello-installer --capsule-tftp)
4. Note the configuration of a feature (e.g. katello-installer --help | grep tftp) shows:
--capsule-tftp Use TFTP (default: true)

Expected results:

Currently, the meaning of 'default' as expressed means 'default values for all future invocations of katello-installer'. However, the user expects default to mean "values 'as shipped from the factory'".

It would make sense to change 'default' to reflect 'current' as well as documenting the 'factory shipped defaults' (either in katello-installer --help or elsewhere) such as (as an example):

--capsule-tftp                Use TFTP (current: true | default: false)

Associated revisions

Revision 20f69dae (diff)
Added by Dominic Cleal almost 3 years ago

fixes #15903 - show current vs default values in help output (#196)

Unifies display of default/value in interactive mode with help output.

History

#1 Updated by Stephen Benjamin about 3 years ago

  • Project changed from Foreman to Kafo
  • Subject changed from katello-installer --help displays currently configured settings as 'default' to help displays currently configured settings as 'default'

#2 Updated by The Foreman Bot almost 3 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Dominic Cleal
  • Pull request https://github.com/theforeman/kafo/pull/196 added

#3 Updated by Dominic Cleal almost 3 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#4 Updated by Daniel Lobato Garcia almost 3 years ago

  • Bugzilla link changed from 1124327 to 1402061

Also available in: Atom PDF