Bug #16564
"Missing frozen string literal comment." rubocop violations on develop
| Status: | Closed | ||
|---|---|---|---|
| Priority: | Normal | ||
| Assignee: |  Tomer Brisker | ||
| Category: | Tests | ||
| Target version: | 1.14.0 | ||
| Difficulty: | Team Backlog: | ||
| Triaged: | Fixed in Releases: | ||
| Bugzilla link: | Found in Releases: | ||
| Pull request: | https://github.com/theforeman/foreman/pull/3846 | ||
Description
All files are failing rubocop checks since #16491 with the following error:
app/models/host.rb:1:1: C: Missing frozen string literal comment.
module Host
^The Style/FrozenStringLiteralComment cop should be disabled or fixed.
There are also failures in config/initializers/secure_headers.rb that aren't passing, probably from when the PR was merged onto develop without re-checking it passed on the previous commit.
Related issues
Associated revisions
Fixes #16564 - Disable FrozenStringLiteralComment cop
Also fixes a failng cop in config/initializers/secure_headers.rb
History
#1
Updated by Dominic Cleal almost 2 years ago
- Related to Bug #16491: upgrade rubocop to version 0.42 added
#2
Updated by Tomer Brisker almost 2 years ago
- Status changed from New to Assigned
- Assignee set to Tomer Brisker
#3
Updated by The Foreman Bot almost 2 years ago
- Status changed from Assigned to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/3846 added
#4 Updated by Anonymous almost 2 years ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset e1c558431f19f8498a01f2c5c426be37b34bd90e.
#5
Updated by Dominic Cleal almost 2 years ago
- Legacy Backlogs Release (now unused) set to 189
#6
Updated by Daniel Lobato Garcia almost 2 years ago
- Target version set to 1.5.2
#7
Updated by David Davis almost 2 years ago
- Related to Bug #16676: "Missing frozen string literal comment." rubocop violations added