Project

General

Profile

Bug #16765

IPAM unused IP error: undefined method `include?' for nil:NilClass

Added by tomas nemame almost 4 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Network
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

Hi,

i have problem with internal IPAM
auto suggestion doesn't work, seems to be a problem with "taken_ips"=>["", ""] undefined method include? for nil:NilClass
for more information, please see attached ipam log

  1. hammer subnet info --id 2
    Id: 2
    Name: BestDC-1.1.1.122-130
    Network: 1.1.1.0
    Mask: 255.255.255.0
    Priority:
    DNS: foreman.domain.tld (https://foreman.domain.tld:8443)
    Primary DNS: 8.8.8.8
    Secondary DNS: 8.8.4.4
    TFTP: foreman.domain.tld (https://foreman.domain.tld:8443)
    DHCP: foreman.domain.tld (https://foreman.domain.tld:8443)
    IPAM: Internal DB
    VLAN ID:
    Gateway: 1.1.1.1
    From: 1.1.1.122
    To: 1.1.1.130
    Domains:
    domain.tld
ipam-bug.txt ipam-bug.txt 16.1 KB tomas nemame, 10/01/2016 07:06 PM

Related issues

Related to Foreman - Feature #14661: Support IPv6 SubnetsClosed2016-04-15

Associated revisions

Revision ce52ced8 (diff)
Added by Marek Hulán almost 4 years ago

Fixes #16765 - DB IPAM works with excluded IPs

Revision d93bb47e (diff)
Added by Marek Hulán almost 4 years ago

Fixes #16765 - DB IPAM works with excluded IPs

(cherry picked from commit ce52ced8ba7904566048b4dc4f4a581ec08ab118)

History

#1 Updated by Dominic Cleal almost 4 years ago

  • Project changed from Plugins to Foreman
  • Subject changed from IPAM error to IPAM unused IP error: undefined method `include?' for nil:NilClass
  • Category set to Network
  • Priority changed from High to Normal
  • Difficulty deleted (easy)

#2 Updated by Marek Hulán almost 4 years ago

#3 Updated by Marek Hulán almost 4 years ago

  • Status changed from New to Assigned
  • Assignee set to Marek Hulán

Introduced by https://github.com/theforeman/foreman/commit/e263719ad3ac70f56ab8fa3511a733d82b3e4833#diff-150923539d83f563f47fbf488e6ee017R56:typo in rubocop PR. Anyway the fix adds extra level of safety since suggest_ip now uses attribute which is not guaranteed to be present.

#4 Updated by The Foreman Bot almost 4 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3908 added

#5 Updated by Dominic Cleal almost 4 years ago

  • Legacy Backlogs Release (now unused) set to 160

#6 Updated by Marek Hulán almost 4 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF